Module:Abilities/card - Revision history

Vergir: undo the undo, it works now

2026-07-31T12:59:42Z

undo the undo, it works now

← Older revision		Revision as of 12:59, 31 July 2026
Line 3:		Line 3:
	local utils = require "Module:Abilities/utils"		local utils = require "Module:Abilities/utils"
	local Icon = require"Module:Abilities/icon"		local Icon = require"Module:Abilities/icon"
			local textfit = require "Module:TextFit"

	local p = {}		local p = {}
Line 415:		Line 416:
	local alt_boxes = {}		local alt_boxes = {}

	for k, prop in ~~pairs~~(props) do		for k, prop in ipairs(props) do
	-- Some props don't have values, as those come from upgrades		-- Some props don't have values, as those come from upgrades
	-- For now, we will ignore these and only show data for the base ability		-- For now, we will ignore these and only show data for the base ability
Line 451:		Line 452:

	local UPGRADE_COST_MAP = {1, 2, 5}		local UPGRADE_COST_MAP = {1, 2, 5}

			-- Upgrade description sizing. These are design proportions, not copies of any
			-- CSS measurement: the browser supplies the box width through the container
			-- query on .ac-upgrade-descwrap, so nothing here needs updating if the card's
			-- widths, margins or padding change.
			local UG_DESC_ASPECT = 0.357 -- max height of the text block, as a multiple of its width
			local UG_LINE_HEIGHT = 1.4 -- emitted alongside the size so the two cannot drift
			local UG_MAX_CQW = 11.9 -- ceiling, as % of the text width (~16px on a full-width card)
			local UG_MIN_CQW = 6.7 -- floor (~9px)

	function get_upgrade_boxes(hero_key, ability_num)		function get_upgrade_boxes(hero_key, ability_num)
	local ability = utils.get_ability_card_data(hero_key, ability_num)		local ability = utils.get_ability_card_data(hero_key, ability_num)
Line 460:		Line 471:

	local upgrade_boxes = {}		local upgrade_boxes = {}
	for k, upgrade in ~~pairs~~(upgrades) do		for k, upgrade in ipairs(upgrades) do
	local description = lang.get_string(upgrade.DescKey)		local description = lang.get_string(upgrade.DescKey)
	~~local desc_length = description and #description or 0~~

	-- bypass some keys if they are mistakenly left in game files		-- bypass some keys if they are mistakenly left in game files
Line 482:		Line 492:
	end		end

	-- ~~Vary~~ the ~~font size based on~~ the ~~number~~ of ~~characters to prevent overflow~~		-- Expand once, then size from the text the reader actually sees, rather
	local ~~fontsize~~ = ~~'1rem'~~		-- than from a character count of the unexpanded string.
	~~if desc_length > 30 and desc_length < 51 then~~		local rendered = frame:preprocess(description)
	~~fontsize~~ = ~~'0.9rem'~~		local cqw = textfit.fit(rendered, {
	~~elseif desc_length > 50 and desc_length < 71 then~~		aspect = UG_DESC_ASPECT,
	~~fontsize~~ = ~~'0.8rem'~~		lineHeight = UG_LINE_HEIGHT,
	~~elseif desc_length > 70 then~~		max = UG_MAX_CQW,
	~~fontsize~~ = ~~'0.7rem'~~		min = UG_MIN_CQW,
	~~end~~		})

	local upgrade_scale = pick_scale(upgrade)		local upgrade_scale = pick_scale(upgrade)
Line 498:		Line 508:
	index = k,		index = k,
	cost = UPGRADE_COST_MAP[k],		cost = UPGRADE_COST_MAP[k],
	description = ~~frame:preprocess(description)~~,		description = rendered,
	scale_value = upgrade_scale and commonutils.round_to_sig_fig(upgrade_scale.Value, 3),		scale_value = upgrade_scale and commonutils.round_to_sig_fig(upgrade_scale.Value, 3),
	scale_type = upgrade_scale and upgrade_scale.Type,		scale_type = upgrade_scale and upgrade_scale.Type,
	fontsize = ~~fontsize~~		-- Measured against the box's own width, so the size stays correct
			-- when the card renders below its 500px max-width.
			fontsize = string.format('%.2fcqw', cqw),
			lineheight = UG_LINE_HEIGHT
	}		}
	}		}

Vergir: Undo revision 104482 by ~2026-SlotReloadHex823 broke it, revert to investigate

2026-07-31T12:07:55Z

Undo revision 104482 by ~2026-SlotReloadHex823 broke it, revert to investigate

← Older revision		Revision as of 12:07, 31 July 2026
Line 3:		Line 3:
	local utils = require "Module:Abilities/utils"		local utils = require "Module:Abilities/utils"
	local Icon = require"Module:Abilities/icon"		local Icon = require"Module:Abilities/icon"
	~~local textfit = require "Module:TextFit"~~

	local p = {}		local p = {}
Line 416:		Line 415:
	local alt_boxes = {}		local alt_boxes = {}

	for k, prop in ~~ipairs~~(props) do		for k, prop in pairs(props) do
	-- Some props don't have values, as those come from upgrades		-- Some props don't have values, as those come from upgrades
	-- For now, we will ignore these and only show data for the base ability		-- For now, we will ignore these and only show data for the base ability
Line 452:		Line 451:

	local UPGRADE_COST_MAP = {1, 2, 5}		local UPGRADE_COST_MAP = {1, 2, 5}

	~~-- Upgrade description sizing. These are design proportions, not copies of any~~
	~~-- CSS measurement: the browser supplies the box width through the container~~
	~~-- query on .ac-upgrade-descwrap, so nothing here needs updating if the card's~~
	~~-- widths, margins or padding change.~~
	~~local UG_DESC_ASPECT = 0.357 -- max height of the text block, as a multiple of its width~~
	~~local UG_LINE_HEIGHT = 1.4 -- emitted alongside the size so the two cannot drift~~
	~~local UG_MAX_CQW = 11.9 -- ceiling, as % of the text width (~16px on a full-width card)~~
	~~local UG_MIN_CQW = 6.7 -- floor (~9px)~~

	function get_upgrade_boxes(hero_key, ability_num)		function get_upgrade_boxes(hero_key, ability_num)
	local ability = utils.get_ability_card_data(hero_key, ability_num)		local ability = utils.get_ability_card_data(hero_key, ability_num)
Line 471:		Line 460:

	local upgrade_boxes = {}		local upgrade_boxes = {}
	for k, upgrade in ~~ipairs~~(upgrades) do		for k, upgrade in pairs(upgrades) do
	local description = lang.get_string(upgrade.DescKey)		local description = lang.get_string(upgrade.DescKey)
			local desc_length = description and #description or 0

	-- bypass some keys if they are mistakenly left in game files		-- bypass some keys if they are mistakenly left in game files
Line 492:		Line 482:
	end		end

	-- ~~Expand once, then~~ size ~~from the text~~ the ~~reader actually sees, rather~~		-- Vary the font size based on the number of characters to prevent overflow
	~~-- than from a character count~~ of ~~the unexpanded string.~~		local fontsize = '1rem'
	local ~~rendered~~ = ~~frame:preprocess(description)~~		if desc_length > 30 and desc_length < 51 then
	~~local cqw~~ = ~~textfit~~.~~fit(rendered, {~~		fontsize = '0.9rem'
	~~aspect = UG_DESC_ASPECT,~~		elseif desc_length > 50 and desc_length < 71 then
	~~lineHeight~~ = ~~UG_LINE_HEIGHT,~~		fontsize = '0.8rem'
	~~max = UG_MAX_CQW,~~		elseif desc_length > 70 then
	~~min~~ = ~~UG_MIN_CQW,~~		fontsize = '0.7rem'
	})		end

	local upgrade_scale = pick_scale(upgrade)		local upgrade_scale = pick_scale(upgrade)
Line 508:		Line 498:
	index = k,		index = k,
	cost = UPGRADE_COST_MAP[k],		cost = UPGRADE_COST_MAP[k],
	description = ~~rendered~~,		description = frame:preprocess(description),
	scale_value = upgrade_scale and commonutils.round_to_sig_fig(upgrade_scale.Value, 3),		scale_value = upgrade_scale and commonutils.round_to_sig_fig(upgrade_scale.Value, 3),
	scale_type = upgrade_scale and upgrade_scale.Type,		scale_type = upgrade_scale and upgrade_scale.Type,
	~~-- Measured against the box's own width, so the size stays correct~~		fontsize = fontsize
	~~-- when the card renders below its 500px max-width.~~
	fontsize = ~~string.format('%.2fcqw', cqw),~~
	~~lineheight = UG_LINE_HEIGHT~~
	}		}
	}		}

~2026-SlotReloadHex823: Size upgrade descriptions by measuring the rendered text against the box instead of counting bytes of the raw string, fixing punctuation and non-English localisations (with help from vergir-bot LLM)

2026-07-31T12:04:47Z

Size upgrade descriptions by measuring the rendered text against the box instead of counting bytes of the raw string, fixing punctuation and non-English localisations (with help from vergir-bot LLM)

← Older revision		Revision as of 12:04, 31 July 2026
Line 3:		Line 3:
	local utils = require "Module:Abilities/utils"		local utils = require "Module:Abilities/utils"
	local Icon = require"Module:Abilities/icon"		local Icon = require"Module:Abilities/icon"
			local textfit = require "Module:TextFit"

	local p = {}		local p = {}
Line 415:		Line 416:
	local alt_boxes = {}		local alt_boxes = {}

	for k, prop in ~~pairs~~(props) do		for k, prop in ipairs(props) do
	-- Some props don't have values, as those come from upgrades		-- Some props don't have values, as those come from upgrades
	-- For now, we will ignore these and only show data for the base ability		-- For now, we will ignore these and only show data for the base ability
Line 451:		Line 452:

	local UPGRADE_COST_MAP = {1, 2, 5}		local UPGRADE_COST_MAP = {1, 2, 5}

			-- Upgrade description sizing. These are design proportions, not copies of any
			-- CSS measurement: the browser supplies the box width through the container
			-- query on .ac-upgrade-descwrap, so nothing here needs updating if the card's
			-- widths, margins or padding change.
			local UG_DESC_ASPECT = 0.357 -- max height of the text block, as a multiple of its width
			local UG_LINE_HEIGHT = 1.4 -- emitted alongside the size so the two cannot drift
			local UG_MAX_CQW = 11.9 -- ceiling, as % of the text width (~16px on a full-width card)
			local UG_MIN_CQW = 6.7 -- floor (~9px)

	function get_upgrade_boxes(hero_key, ability_num)		function get_upgrade_boxes(hero_key, ability_num)
	local ability = utils.get_ability_card_data(hero_key, ability_num)		local ability = utils.get_ability_card_data(hero_key, ability_num)
Line 460:		Line 471:

	local upgrade_boxes = {}		local upgrade_boxes = {}
	for k, upgrade in ~~pairs~~(upgrades) do		for k, upgrade in ipairs(upgrades) do
	local description = lang.get_string(upgrade.DescKey)		local description = lang.get_string(upgrade.DescKey)
	~~local desc_length = description and #description or 0~~

	-- bypass some keys if they are mistakenly left in game files		-- bypass some keys if they are mistakenly left in game files
Line 482:		Line 492:
	end		end

	-- ~~Vary~~ the ~~font size based on~~ the ~~number~~ of ~~characters to prevent overflow~~		-- Expand once, then size from the text the reader actually sees, rather
	local ~~fontsize~~ = ~~'1rem'~~		-- than from a character count of the unexpanded string.
	~~if desc_length > 30 and desc_length < 51 then~~		local rendered = frame:preprocess(description)
	~~fontsize~~ = ~~'0.9rem'~~		local cqw = textfit.fit(rendered, {
	~~elseif desc_length > 50 and desc_length < 71 then~~		aspect = UG_DESC_ASPECT,
	~~fontsize~~ = ~~'0.8rem'~~		lineHeight = UG_LINE_HEIGHT,
	~~elseif desc_length > 70 then~~		max = UG_MAX_CQW,
	~~fontsize~~ = ~~'0.7rem'~~		min = UG_MIN_CQW,
	~~end~~		})

	local upgrade_scale = pick_scale(upgrade)		local upgrade_scale = pick_scale(upgrade)
Line 498:		Line 508:
	index = k,		index = k,
	cost = UPGRADE_COST_MAP[k],		cost = UPGRADE_COST_MAP[k],
	description = ~~frame:preprocess(description)~~,		description = rendered,
	scale_value = upgrade_scale and commonutils.round_to_sig_fig(upgrade_scale.Value, 3),		scale_value = upgrade_scale and commonutils.round_to_sig_fig(upgrade_scale.Value, 3),
	scale_type = upgrade_scale and upgrade_scale.Type,		scale_type = upgrade_scale and upgrade_scale.Type,
	fontsize = ~~fontsize~~		-- Measured against the box's own width, so the size stays correct
			-- when the card renders below its 500px max-width.
			fontsize = string.format('%.2fcqw', cqw),
			lineheight = UG_LINE_HEIGHT
	}		}
	}		}

~2026-DynamoMoCamps780: Keep zero-valued scalings from multi-scaling attributes so the placeholder badge still renders and upgrades can populate it, fixing Doorman's Doorway distance scaling (with help from vergir-bot LLM)

2026-07-27T01:03:30Z

Keep zero-valued scalings from multi-scaling attributes so the placeholder badge still renders and upgrades can populate it, fixing Doorman's Doorway distance scaling (with help from vergir-bot LLM)

← Older revision		Revision as of 01:03, 27 July 2026
Line 198:		Line 198:
	-- healing, charges) that always hold a value of 1 and are never displayed, so		-- healing, charges) that always hold a value of 1 and are never displayed, so
	-- return the first entry that actually renders a badge.		-- return the first entry that actually renders a badge.
			-- A zero-valued scaling is still returned when nothing else is displayable. The
			-- card renders it as an x0 placeholder, and the ability upgrade gadget fills
			-- that element in when an upgrade grants real scaling (Doorman's Doorway).
	local function pick_scale(attr)		local function pick_scale(attr)
	if not attr then		if not attr then
Line 213:		Line 216:
	end		end

			local placeholder = nil
	for _, entry in ipairs(scale) do		for _, entry in ipairs(scale) do
	if type(entry) == 'table' ~~and entry.Value ~= 0~~ and Icon.isDisplayedScale(entry.Type) then		if type(entry) == 'table' and Icon.isDisplayedScale(entry.Type) then
	return entry		if entry.Value ~= 0 then
			return entry
			end
			placeholder = placeholder or entry
	end		end
	end		end

	return ~~nil~~		return placeholder
	end		end

~2026-DecayDurationBase778: Handle attributes carrying multiple scalings by picking the first one that renders, so real coefficients are not dropped when paired with a hidden stat-category marker (with help from vergir-bot LLM)

2026-07-26T21:33:02Z

Handle attributes carrying multiple scalings by picking the first one that renders, so real coefficients are not dropped when paired with a hidden stat-category marker (with help from vergir-bot LLM)

← Older revision		Revision as of 21:33, 26 July 2026
Line 194:		Line 194:
	end		end

	-- ~~Get~~ scaling of ~~attribute~~, return ~~nil if none is found~~		-- An attribute may carry either a single scaling or a list of them.
	function ~~get_attr_scale~~(attr)		-- Extra entries are stat-category markers (duration, cooldown, range, radius,
	if not attr then		-- healing, charges) that always hold a value of 1 and are never displayed, so
	return nil		-- return the first entry that actually renders a badge.
			local function pick_scale(attr)
			if not attr then
			return nil
	end		end

	local scale = attr.Scale		local scale = attr.Scale
			if type(scale) ~= 'table' then
			return nil
			end

			-- A single scaling is stored directly as an object
			if scale[1] == nil then
			return scale
			end

			for _, entry in ipairs(scale) do
			if type(entry) == 'table' and entry.Value ~= 0 and Icon.isDisplayedScale(entry.Type) then
			return entry
			end
			end

			return nil
			end

			-- Get scaling of attribute, return nil if none is found
			function get_attr_scale(attr)
			local scale = pick_scale(attr)
	if not scale then		if not scale then
	return nil		return nil
Line 214:		Line 238:
	-- Get scaling type of attribute, return nil if none is found		-- Get scaling type of attribute, return nil if none is found
	function get_attr_scale_type(attr)		function get_attr_scale_type(attr)
	~~if not attr then~~		local scale = pick_scale(attr)
	~~return nil~~
	~~end~~

	local scale = attr~~.Scale~~
	if not scale then		if not scale then
	return nil		return nil
Line 232:		Line 252:
	-- Check if scaling should be multiplied instead of added		-- Check if scaling should be multiplied instead of added
	function get_attr_scale_multiply(attr)		function get_attr_scale_multiply(attr)
	~~if not attr then~~		local scale = pick_scale(attr)
	~~return nil~~
	~~end~~

	local scale = attr~~.Scale~~
	if not scale then		if not scale then
	return nil		return nil
Line 310:		Line 326:
	for k, prop in ipairs(props) do -- use ipairs for ordered iteration		for k, prop in ipairs(props) do -- use ipairs for ordered iteration
	local value = prop.Value		local value = prop.Value
			local scale = pick_scale(prop)
	-- If it scales with melee damage, set the value using the hero's base melee to match in game visuals		-- If it scales with melee damage, set the value using the hero's base melee to match in game visuals
	if ~~prop.Scale~~ and ~~prop.Scale~~.Type == 'melee' then		if scale and scale.Type == 'melee' then
	local hero = get_hero_data(hero_key)		local hero = get_hero_data(hero_key)
	value = prop.Value + hero.LightMeleeDamage * ~~prop.Scale~~.Value		value = prop.Value + hero.LightMeleeDamage * scale.Value
	elseif ~~prop.Scale~~ and ~~prop.Scale~~.Type == 'heavy_melee' then		elseif scale and scale.Type == 'heavy_melee' then
	local hero = get_hero_data(hero_key)		local hero = get_hero_data(hero_key)
	value = prop.Value + hero.HeavyMeleeDamage * ~~prop.Scale~~.Value		value = prop.Value + hero.HeavyMeleeDamage * scale.Value
	elseif ~~prop.Scale~~ and ~~prop.Scale~~.Type == 'weapon_power' then		elseif scale and scale.Type == 'weapon_power' then
	local hero = get_hero_data(hero_key)		local hero = get_hero_data(hero_key)
	value = hero.Weapon.BulletDamage * hero.Weapon.BulletsPerBurst * (~~prop.Scale~~.Value + 100) / 100		value = hero.Weapon.BulletDamage * hero.Weapon.BulletsPerBurst * (scale.Value + 100) / 100
	end		end

Line 337:		Line 354:
	icon_color = icon and icon.color,		icon_color = icon and icon.color,
	icon_size = icon and icon.size,		icon_size = icon and icon.size,
	scale_value = ~~prop.Scale~~ and commonutils.round_to_sig_fig(~~prop.Scale~~.Value, 3),		scale_value = scale and commonutils.round_to_sig_fig(scale.Value, 3),
	scale_type = ~~prop.Scale~~ and ~~prop.Scale~~.Type,		scale_type = scale and scale.Type,
	-- allow nil value here as some status effects don't have a value but should not be hidden		-- allow nil value here as some status effects don't have a value but should not be hidden
	hide = value == 0 and "true" or "false",		hide = value == 0 and "true" or "false",
Line 354:		Line 371:
	icon_color = icon and icon.color,		icon_color = icon and icon.color,
	icon_size = icon and icon.size,		icon_size = icon and icon.size,
	scale_value = ~~prop.Scale~~ and commonutils.round_to_sig_fig(~~prop.Scale~~.Value, 3),		scale_value = scale and commonutils.round_to_sig_fig(scale.Value, 3),
	scale_type = ~~prop.Scale~~ and ~~prop.Scale~~.Type,		scale_type = scale and scale.Type,
	hide = (value == nil or value == 0) and "true" or "false",		hide = (value == nil or value == 0) and "true" or "false",
	}		}
Line 398:		Line 415:

	local value = prop.Value		local value = prop.Value
			local scale = pick_scale(prop)

	if ~~prop.Scale~~ and ~~prop.Scale~~.Type == 'weapon_power' then		if scale and scale.Type == 'weapon_power' then
	local hero = get_hero_data(hero_key)		local hero = get_hero_data(hero_key)
	value = hero.Weapon.BulletDamage * hero.Weapon.BulletsPerBurst * (~~prop.Scale~~.Value + 100) / 100		value = hero.Weapon.BulletDamage * hero.Weapon.BulletsPerBurst * (scale.Value + 100) / 100
	end		end

Line 413:		Line 431:
	icon_color = icon and icon.color,		icon_color = icon and icon.color,
	icon_size = icon and icon.size,		icon_size = icon and icon.size,
	scale_value = ~~prop.Scale~~ and commonutils.round_to_sig_fig(~~prop.Scale~~.Value, 3),		scale_value = scale and commonutils.round_to_sig_fig(scale.Value, 3),
	scale_type = ~~prop.Scale~~ and ~~prop.Scale~~.Type,		scale_type = scale and scale.Type,
	hide = value == 0 and "true" or "false",		hide = value == 0 and "true" or "false",
	}		}
Line 467:		Line 485:
	end		end

			local upgrade_scale = pick_scale(upgrade)
	local upgrade_box = frame:expandTemplate{		local upgrade_box = frame:expandTemplate{
	title = "Ability_card_v2/Card/UpgradeBox",		title = "Ability_card_v2/Card/UpgradeBox",
Line 473:		Line 492:
	cost = UPGRADE_COST_MAP[k],		cost = UPGRADE_COST_MAP[k],
	description = frame:preprocess(description),		description = frame:preprocess(description),
	scale_value = ~~upgrade.Scale~~ and commonutils.round_to_sig_fig(~~upgrade.Scale~~.Value, 3),		scale_value = upgrade_scale and commonutils.round_to_sig_fig(upgrade_scale.Value, 3),
	scale_type = ~~upgrade.Scale~~ and ~~upgrade.Scale~~.Type,		scale_type = upgrade_scale and upgrade_scale.Type,
	fontsize = fontsize		fontsize = fontsize
	}		}

LVL: Fix missing AbilityCharges HTML element for JS gadget by defaulting num_of_charges to 0

2026-06-18T14:11:47Z

Fix missing AbilityCharges HTML element for JS gadget by defaulting num_of_charges to 0

← Older revision		Revision as of 14:11, 18 June 2026
Line 124:		Line 124:
	charge_cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldownBetweenCharge),		charge_cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldownBetweenCharge),
	charge_cooldown_scale_multiply = get_attr_scale_multiply(ability.AbilityCooldownBetweenCharge),		charge_cooldown_scale_multiply = get_attr_scale_multiply(ability.AbilityCooldownBetweenCharge),
	num_of_charges = ability.AbilityCharges and ability.AbilityCharges.Value,		num_of_charges = ability.AbilityCharges and ability.AbilityCharges.Value or 0,

	-- Info section #1 defined in "Info1" attribute		-- Info section #1 defined in "Info1" attribute
Line 654:		Line 654:
	charge_cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldownBetweenCharge),		charge_cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldownBetweenCharge),
	charge_cooldown_scale_multiply = get_attr_scale_multiply(ability.AbilityCooldownBetweenCharge),		charge_cooldown_scale_multiply = get_attr_scale_multiply(ability.AbilityCooldownBetweenCharge),
	num_of_charges = ability.AbilityCharges and ability.AbilityCharges.Value,		num_of_charges = ability.AbilityCharges and ability.AbilityCharges.Value or 0,
	}		}
	}		}

Gammaton32: weapon power scaling value

2026-06-16T22:20:19Z

weapon power scaling value

← Older revision		Revision as of 22:20, 16 June 2026
Line 317:		Line 317:
	local hero = get_hero_data(hero_key)		local hero = get_hero_data(hero_key)
	value = prop.Value + hero.HeavyMeleeDamage * prop.Scale.Value		value = prop.Value + hero.HeavyMeleeDamage * prop.Scale.Value
			elseif prop.Scale and prop.Scale.Type == 'weapon_power' then
			local hero = get_hero_data(hero_key)
			value = hero.Weapon.BulletDamage * hero.Weapon.BulletsPerBurst * (prop.Scale.Value + 100) / 100
	end		end

Line 388:		Line 391:
	local alt_boxes = {}		local alt_boxes = {}

	for k, prop in pairs(props) do		for k, prop in pairs(props) do
	-- Some props don't have values, as those come from upgrades		-- Some props don't have values, as those come from upgrades
	-- For now, we will ignore these and only show data for the base ability		-- For now, we will ignore these and only show data for the base ability
	if prop.Value then		if prop.Value then
	local icon = Icon.getAttrIcon(prop.Type)		local icon = Icon.getAttrIcon(prop.Type)
	local alt_box = frame:expandTemplate{
	title = "Ability_card_v2/Card/AltBox",		local value = prop.Value
	args = {
	key = prop.Key,		if prop.Scale and prop.Scale.Type == 'weapon_power' then
	value = ~~prop.Value~~,		local hero = get_hero_data(hero_key)
	icon = icon and icon.img,		value = hero.Weapon.BulletDamage * hero.Weapon.BulletsPerBurst * (prop.Scale.Value + 100) / 100
	icon_link = icon and icon.link,		end
	icon_color = icon and icon.color,
	icon_size = icon and icon.size,		local alt_box = frame:expandTemplate{
	scale_value = prop.Scale and commonutils.round_to_sig_fig(prop.Scale.Value, 3),		title = "Ability_card_v2/Card/AltBox",
	scale_type = prop.Scale and prop.Scale.Type,		args = {
	hide = ~~prop.Value~~ == 0 and "true" or "false",		key = prop.Key,
	}		value = value,
	}		icon = icon and icon.img,
	table.insert(alt_boxes, alt_box)		icon_link = icon and icon.link,
	end		icon_color = icon and icon.color,
	end		icon_size = icon and icon.size,
			scale_value = prop.Scale and commonutils.round_to_sig_fig(prop.Scale.Value, 3),
			scale_type = prop.Scale and prop.Scale.Type,
			hide = value == 0 and "true" or "false",
			}
			}
			table.insert(alt_boxes, alt_box)
			end
			end

	return alt_boxes		return alt_boxes

LVL: Fix Fire Scarabs T3 upgrade description: suppress "0 DPS" and show "Increased Spirit scaling". Refactor create_description to handle scaling‑only properties

2026-06-12T15:34:31Z

Fix Fire Scarabs T3 upgrade description: suppress "0 DPS" and show "Increased Spirit scaling". Refactor create_description to handle scaling‑only properties

← Older revision		Revision as of 15:34, 12 June 2026
Line 475:		Line 475:

	function create_description(prop, frame)		function create_description(prop, frame)
	local ~~description~~ = ''		local value_lines = {} -- normal stat changes
	local ~~first~~ = ~~true~~		local scale_lines = {} -- "Increased X scaling" notes
	local seen = {} ~~-- Set to track added combinations~~		local seen = {}

	for k, v in pairs(prop) do		for k, v in pairs(prop) do
	~~local value~~		if k == 'DescKey' then
	if type(v) == 'table' then		-- skip
	~~value~~ = v.Value		elseif type(v) == 'table' then
	~~else~~		local has_value = v.Value ~= nil
	value = v		local has_scale = v.Scale and v.Scale.Value and v.Scale.Value ~= 0
	end
			-- Value is 0 and we have a scaling change → scaling note
	local formatted_value = utils.format_value_with_prepost(k, ~~value~~, frame)		if has_value and has_scale and v.Value == 0 then
	local attr_name = lang.get_string(k..'_label')		if not seen["scale_" .. k] then
	local key = formatted_value .. '\|' .. attr_name ~~-- Unique identifier~~		local scale_type = v.Scale.Type
			local capitalized = scale_type:sub(1,1):upper() .. scale_type:sub(2)
	~~-- skip DescKey for the edge case where we are generating description instead of using localization files~~		table.insert(scale_lines, "Increased " .. capitalized .. " scaling")
	~~if k ~=~~ '~~DescKey~~' ~~then~~		seen["scale_" .. k] = true
	~~-- Skip if this combination has already been added~~		end
	~~if not~~ seen[key] ~~then~~		-- Only a scaling change, no value → scaling note (future bot correction)
	-- ~~Add line break if this is not the first item~~		elseif not has_value and has_scale then
	~~if not first then~~		if not seen["scale_" .. k] then
	~~description~~ = ~~description~~ .. '~~<br>~~'		local scale_type = v.Scale.Type
	~~end~~		local capitalized = scale_type:sub(1,1):upper() .. scale_type:sub(2)
	~~end~~		table.insert(scale_lines, "Increased " .. capitalized .. " scaling")
			seen["scale_" .. k] = true
	~~description = description .~~. string.format('%s %s', formatted_value, attr_name)		end
	~~first = false~~		-- Normal value (0 without scale, or non‑zero with/without scale)
	seen[key] = true ~~-- Mark this combination as added~~		elseif has_value then
			local formatted_value = utils.format_value_with_prepost(k, v.Value, frame)
			local attr_name = lang.get_string(k .. '_label')
			local key = formatted_value .. '\|' .. attr_name
			if not seen[key] then
			table.insert(value_lines, string.format('%s %s', formatted_value, attr_name))
			seen[key] = true
			end
			end
			else
			-- Plain number/string (e.g. OutgoingDamagePenaltyPercent = -15)
			local formatted_value = utils.format_value_with_prepost(k, v, frame)
			local attr_name = lang.get_string(k .. '_label')
			local key = formatted_value .. '\|' .. attr_name
			if not seen[key] then
			table.insert(value_lines, string.format('%s %s', formatted_value, attr_name))
			seen[key] = true
			end
	end		end
	end		end

	return ~~description~~		-- Combine: value lines first, then scaling lines
			local all_lines = {}
			for _, line in ipairs(value_lines) do
			table.insert(all_lines, line)
			end
			for _, line in ipairs(scale_lines) do
			table.insert(all_lines, line)
			end

			return table.concat(all_lines, '<br>')
	end		end

LVL: Removed hex duration as it seems to work without this code now.

2026-06-03T19:34:04Z

Removed hex duration as it seems to work without this code now.

@@ Line 62: / Line 62: @@
 	local info1_desc = get_info_desc(hero_key, ability_num, 1)
 	local info1_main_boxes = get_main_boxes(hero_key, ability_num, 1)
 	local info1_alt_boxes = get_alt_boxes(hero_key, ability_num, 1)

Gammaton32: added multiply function

2026-05-23T16:50:14Z

added multiply function

← Older revision		Revision as of 16:50, 23 May 2026
Line 121:		Line 121:
	channel_time_scale = get_attr_scale(ability.AbilityChannelTime),		channel_time_scale = get_attr_scale(ability.AbilityChannelTime),
	channel_time_scale_type = get_attr_scale_type(ability.AbilityChannelTime),		channel_time_scale_type = get_attr_scale_type(ability.AbilityChannelTime),
			channel_time_scale_multiply = get_attr_scale_multiply(ability.AbilityChannelTime),
	radius = ability.Radius and ability.Radius.Value,		radius = ability.Radius and ability.Radius.Value,
	radius_scale = get_attr_scale(ability.Radius),		radius_scale = get_attr_scale(ability.Radius),
	radius_scale_type = get_attr_scale_type(ability.Radius),		radius_scale_type = get_attr_scale_type(ability.Radius),
			radius_scale_multiply = get_attr_scale_multiply(ability.Radius),
	range = ability.AbilityCastRange and ability.AbilityCastRange.Value,		range = ability.AbilityCastRange and ability.AbilityCastRange.Value,
	range_scale = get_attr_scale(ability.AbilityCastRange),		range_scale = get_attr_scale(ability.AbilityCastRange),
	range_scale_type = get_attr_scale_type(ability.AbilityCastRange),		range_scale_type = get_attr_scale_type(ability.AbilityCastRange),
			range_scale_multiply = get_attr_scale_multiply(ability.AbilityCastRange),
	duration = ability.AbilityDuration and ability.AbilityDuration.Value,		duration = ability.AbilityDuration and ability.AbilityDuration.Value,
	duration_scale = get_attr_scale(ability.AbilityDuration),		duration_scale = get_attr_scale(ability.AbilityDuration),
	duration_scale_type = get_attr_scale_type(ability.AbilityDuration),		duration_scale_type = get_attr_scale_type(ability.AbilityDuration),
			duration_scale_multiply = get_attr_scale_multiply(ability.AbilityDuration),
	-- ability_width = format_value_with_prepost(width_key, ability[width_key]),		-- ability_width = format_value_with_prepost(width_key, ability[width_key]),
	cooldown =ability.AbilityCooldown and ability.AbilityCooldown.Value,		cooldown =ability.AbilityCooldown and ability.AbilityCooldown.Value,
	cooldown_scale = get_attr_scale(ability.AbilityCooldown),		cooldown_scale = get_attr_scale(ability.AbilityCooldown),
	cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldown),		cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldown),
			cooldown_scale_multiply = get_attr_scale_multiply(ability.AbilityCooldown),
	charge_cooldown = ability.AbilityCooldownBetweenCharge and ability.AbilityCooldownBetweenCharge.Value ~= -1 and ability.AbilityCooldownBetweenCharge.Value,		charge_cooldown = ability.AbilityCooldownBetweenCharge and ability.AbilityCooldownBetweenCharge.Value ~= -1 and ability.AbilityCooldownBetweenCharge.Value,
	charge_cooldown_scale = get_attr_scale(ability.AbilityCooldownBetweenCharge),		charge_cooldown_scale = get_attr_scale(ability.AbilityCooldownBetweenCharge),
	charge_cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldownBetweenCharge),		charge_cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldownBetweenCharge),
			charge_cooldown_scale_multiply = get_attr_scale_multiply(ability.AbilityCooldownBetweenCharge),
	num_of_charges = ability.AbilityCharges and ability.AbilityCharges.Value,		num_of_charges = ability.AbilityCharges and ability.AbilityCharges.Value,

Line 207:		Line 213:
	end		end

	-- Get ~~spirit~~ scaling of attribute, return nil if none is found		-- Get scaling of attribute, return nil if none is found
	function get_attr_scale(attr)		function get_attr_scale(attr)
	if not attr then		if not attr then
Line 225:		Line 231:
	end		end

			-- Get scaling type of attribute, return nil if none is found
	function get_attr_scale_type(attr)		function get_attr_scale_type(attr)
	if not attr then		if not attr then
Line 240:		Line 247:

	return scale.Type		return scale.Type
			end

			-- Check if scaling should be multiplied instead of added
			function get_attr_scale_multiply(attr)
			if not attr then
			return nil
			end

			local scale = attr.Scale
			if not scale then
			return nil
			end

			return scale.Multiply
	end		end

Line 590:		Line 611:
	icon = lang.get_string(ability.Key, 'en') .. '.png',		icon = lang.get_string(ability.Key, 'en') .. '.png',
	description = mw.getCurrentFrame():preprocess(lang.get_string(ability.DescKey)),		description = mw.getCurrentFrame():preprocess(lang.get_string(ability.DescKey)),
			channel_time = ability.AbilityChannelTime and ability.AbilityChannelTime.Value ~= 9999 and ability.AbilityChannelTime.Value,
			channel_time_scale = get_attr_scale(ability.AbilityChannelTime),
			channel_time_scale_type = get_attr_scale_type(ability.AbilityChannelTime),
			channel_time_scale_multiply = get_attr_scale_multiply(ability.AbilityChannelTime),
	radius = ability.Radius and ability.Radius.Value,		radius = ability.Radius and ability.Radius.Value,
	radius_scale = get_attr_scale(ability.Radius),		radius_scale = get_attr_scale(ability.Radius),
	radius_scale_type = get_attr_scale_type(ability.Radius),		radius_scale_type = get_attr_scale_type(ability.Radius),
			radius_scale_multiply = get_attr_scale_multiply(ability.Radius),
	range = ability.AbilityCastRange and ability.AbilityCastRange.Value,		range = ability.AbilityCastRange and ability.AbilityCastRange.Value,
	range_scale = get_attr_scale(ability.AbilityCastRange),		range_scale = get_attr_scale(ability.AbilityCastRange),
	range_scale_type = get_attr_scale_type(ability.AbilityCastRange),		range_scale_type = get_attr_scale_type(ability.AbilityCastRange),
			range_scale_multiply = get_attr_scale_multiply(ability.AbilityCastRange),
	duration = ability.AbilityDuration and ability.AbilityDuration.Value,		duration = ability.AbilityDuration and ability.AbilityDuration.Value,
	duration_scale = get_attr_scale(ability.AbilityDuration),		duration_scale = get_attr_scale(ability.AbilityDuration),
	duration_scale_type = get_attr_scale_type(ability.AbilityDuration),		duration_scale_type = get_attr_scale_type(ability.AbilityDuration),
			duration_scale_multiply = get_attr_scale_multiply(ability.AbilityDuration),
	-- ability_width = format_value_with_prepost(width_key, ability[width_key]),		-- ability_width = format_value_with_prepost(width_key, ability[width_key]),
	cooldown =ability.AbilityCooldown and ability.AbilityCooldown.Value,		cooldown =ability.AbilityCooldown and ability.AbilityCooldown.Value,
	cooldown_scale = get_attr_scale(ability.AbilityCooldown),		cooldown_scale = get_attr_scale(ability.AbilityCooldown),
	cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldown),		cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldown),
	charge_cooldown = ability.AbilityCooldownBetweenCharge and ability.AbilityCooldownBetweenCharge.Value,		cooldown_scale_multiply = get_attr_scale_multiply(ability.AbilityCooldown),
			charge_cooldown = ability.AbilityCooldownBetweenCharge and ability.AbilityCooldownBetweenCharge.Value ~= -1 and ability.AbilityCooldownBetweenCharge.Value,
	charge_cooldown_scale = get_attr_scale(ability.AbilityCooldownBetweenCharge),		charge_cooldown_scale = get_attr_scale(ability.AbilityCooldownBetweenCharge),
	charge_cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldownBetweenCharge),		charge_cooldown_scale_type = get_attr_scale_type(ability.AbilityCooldownBetweenCharge),
			charge_cooldown_scale_multiply = get_attr_scale_multiply(ability.AbilityCooldownBetweenCharge),
	num_of_charges = ability.AbilityCharges and ability.AbilityCharges.Value,		num_of_charges = ability.AbilityCharges and ability.AbilityCharges.Value,
	~~notes = notes,~~
	~~notes_source_page = notes_source_page,~~
	}		}
	}		}