Module:AbilityTable/ComplexRenderers: Difference between revisions

Vergir (talk | contribs)
simplify RenderDebuff to just find earliest upgrade tier, remove debuff_short_name table (with help from vergir-bot LLM)
add scalingspirit
 
(9 intermediate revisions by 3 users not shown)
Line 47: Line 47:
end
end


-- Returns true if prop exists with a non-zero value at the top level of the
-- Sums the non-zero values of `fields` within a single record layer (the base
-- record, excluding the Upgrades key. Does not recurse into sub-tables to
-- ability record, or one upgrade tier). Returns nil when none are present.
-- avoid false positives from modifier metadata (e.g. prop names appearing as
local function sum_fields(layer, fields)
-- string values inside AutoRegisterModifierValueFromAbilityPropertyName).
    local total = nil
-- Value-objects like { Value = N } are unwrapped via the k == prop branch.
    for _, field in ipairs(fields) do
-- Name-based list entries (e.g. "Card Trick") match via the string branch
        local v = unwrap_value(layer[field])
-- against the top-level Name field.
        if v and v ~= 0 then total = (total or 0) + math.abs(v) end
local function is_base_property(record, prop)
    end
     for k, v in pairs(record) do
    return total
         if k == "Upgrades" then
end
             -- skip
 
        elseif k == prop then
-- Sums the barrier value and Spirit scaling contributed by a single record
             if type(v) == "table" then v = v["Value"] end
-- layer (the base ability record, or one upgrade tier). Returns nil when the
            if v ~= nil and v ~= 0 and v ~= "" and v ~= "0" and v ~= "0m" then
-- layer grants no barrier at all; a tier that only raises the scaling still
                return true
-- counts, so "+0 value, +1.0 scaling" upgrades are not lost.
local function sum_barrier(layer, fields)
    local value, scale, found = 0, 0, false
     for _, field in ipairs(fields) do
        local entry = layer[field]
         if entry ~= nil then
             local v = unwrap_value(entry) or 0
            local s = 0
             if type(entry) == "table" and type(entry["Scale"]) == "table" then
                s = entry["Scale"]["Value"] or 0
             end
             end
        elseif type(v) == "string" then
            if v ~= 0 or s ~= 0 then found = true end
             if v == prop then return true end
             value = value + v
            scale = scale + s
         end
         end
     end
     end
     return false
     if not found then return nil end
    return value, scale
end
end


-- Finds the base-level melee scale value by scanning for Scale.Type == "melee".
-- Pads a whole-number scaling out to one decimal, so a running total of 2
local function find_base_melee_scale(ability)
-- reads "2.0" next to its "1.5" neighbours instead of "2". Values that already
     for _, v in pairs(ability) do
-- carry decimals are left alone, which keeps precision on things like 0.75.
        if type(v) == "table" then
local function format_scale(scale)
            local scale = v["Scale"]
     local text = tostring(scale)
            if type(scale) == "table"
    if not text:find(".", 1, true) then text = text .. ".0" end
                 and scale["Type"] == "melee"
    return text
                 and type(scale["Value"]) == "number"
end
                and scale["Value"] > 0
 
             then
-- Formats one barrier step. Spirit scaling goes through the compact {{Ss}}
                return scale["Value"]
-- form, expanded via the frame the surrounding #invoke is already running
            end
-- under: module return values are not re-expanded, so a literal "{{Ss|0.8}}"
-- would reach the page as text. The plain fallback covers a nil frame
-- (module console).
local function format_barrier(value, scale)
    local out = tostring(value)
    if scale and scale ~= 0 then
        local scale_text = format_scale(scale)
        local frame = mw.getCurrentFrame()
        if frame then
            out = out .. " " .. frame:expandTemplate{
                 title = "Ss",
                 args  = { scale_text, compact = "1", show_value = "1" },
             }
        else
            out = out .. " ×" .. scale_text
         end
         end
     end
     end
     return nil
     return out
end
end


Line 143: Line 168:


local p = {}
local p = {}
-- Renders the barrier an ability grants, with its Spirit Power scaling.
-- Both the value and the scaling accumulate across upgrades, so every step
-- after the first shows the running total: "100 x0.8 → 180 x1.5 (T2)".
-- A tier that only improves the scaling still gets its own segment.
function p.RenderBarrier(ability)
    local fields  = Lists.lists["barrier"]
    local segments = {}
    local value, scale = sum_barrier(ability, fields)
    if value then
        table.insert(segments, format_barrier(value, scale))
    else
        value, scale = 0, 0
    end
    local upgrades = ability["Upgrades"]
    if type(upgrades) == "table" then
        for i, tier in ipairs(upgrades) do
            if type(tier) == "table" then
                local delta_value, delta_scale = sum_barrier(tier, fields)
                if delta_value then
                    value, scale = value + delta_value, scale + delta_scale
                    table.insert(segments,
                        format_barrier(value, scale) .. " (T" .. i .. ")")
                end
            end
        end
    end
    if #segments == 0 then return {} end
    return { ["Barrier"] = table.concat(segments, " → ") }
end


-- Renders charge count and time between charges.
-- Renders charge count and time between charges.
Line 148: Line 206:
function p.RenderCharges(ability)
function p.RenderCharges(ability)
     local base_charges  = unwrap_value(ability["AbilityCharges"])
     local base_charges  = unwrap_value(ability["AbilityCharges"])
     local base_cooldown = ability["AbilityCooldownBetweenCharge"]
     local base_cooldown = unwrap_value(ability["AbilityCooldownBetweenCharge"])
     local has_base      = base_charges ~= nil and base_charges > 0
     local has_base      = base_charges ~= nil and base_charges > 0
     local upgrade_info  = find_in_upgrades(ability, "AbilityCharges")
     local upgrade_info  = find_in_upgrades(ability, "AbilityCharges")
Line 341: Line 399:
             end
             end
         end
         end
    end
    return cells
end
-- Renders Spirit Power scaling.
-- Shows the Scale.Value for abilities whose Scale.Type is "spirit".
function p.RenderSpiritScaling(ability)
    local base_scale = nil
    local base_prop = nil
    -- Find base Spirit scaling
    for k, v in pairs(ability) do
        if k ~= "Upgrades" and type(v) == "table" then
            local scale = v["Scale"]
            if type(scale) == "table"
              and scale["Type"] == "spirit"
              and type(scale["Value"]) == "number"
              and scale["Value"] ~= 0 then
                base_scale = scale["Value"]
                base_prop = k
                break
            end
        end
    end
    local cells = {}
    if base_scale then
        cells["Spirit Scaling"] = "×" .. base_scale
    end
    local upgrades = ability["Upgrades"]
    if type(upgrades) ~= "table" then return cells end
    local notes = {}
    for i, tier in ipairs(upgrades) do
        if type(tier) == "table" then
            local upgrade_scale = nil
            for k, v in pairs(tier) do
                if type(v) == "table" then
                    local scale = v["Scale"]
                    if type(scale) == "table"
                      and scale["Type"] == "spirit"
                      and type(scale["Value"]) == "number"
                      and scale["Value"] ~= 0 then
                        upgrade_scale = scale["Value"]
                        break
                    end
                end
            end
            if upgrade_scale then
                table.insert(notes,
                    "on T" .. i .. " gets +×" .. upgrade_scale .. " Spirit scaling")
            end
        end
    end
    if #notes > 0 then
        cells["Notes"] = table.concat(notes, ". ")
     end
     end


Line 365: Line 486:
     end
     end
     return render_upgradable_stat(ability, "Heal Reduction", filtered, "%")
     return render_upgradable_stat(ability, "Heal Reduction", filtered, "%")
end
-- Shows a note if an ability only acquires a dispellable debuff via upgrades.
-- Shared by debuffresist and dispelmagic.
function p.RenderDebuff(ability, stat)
    local stat_props = Lists.lists[stat]
    local cells = {}
    -- If any prop exists in base, this is a base-level debuff — no note needed.
    for _, prop in ipairs(stat_props) do
        if is_base_property(ability, prop) then
            return cells
        end
    end
    -- Find the earliest upgrade tier with a matching prop.
    local upgrades = ability["Upgrades"]
    if type(upgrades) ~= "table" then return cells end
    for i, tier in ipairs(upgrades) do
        if type(tier) == "table" then
            for _, prop in ipairs(stat_props) do
                local v = tier[prop]
                if v ~= nil then
                    if type(v) == "table" then v = v["Value"] end
                    if v ~= nil and v ~= 0 and v ~= "" and v ~= "0" and v ~= "0m" then
                        cells["Notes"] = "After T" .. i
                        return cells
                    end
                end
            end
        end
    end
    return cells
end
end


Line 470: Line 556:


     return cells
     return cells
end
-- Renders the amount of Debuff Resist an ability grants.
-- Upgrades stack additively onto the base value, so every step after the first
-- shows the running total: "20% (T3)" when granted only by an upgrade,
-- "10% → 25% (T2)" when a base value is later increased. Chains for any number
-- of steps. No ability currently has both a base and an upgrade value.
function p.RenderExtraDebuffResist(ability)
    local fields  = Lists.lists["extradebuffresist"]
    local segments = {}
    local running = sum_fields(ability, fields)
    if running then
        table.insert(segments, running .. "%")
    end
    local upgrades = ability["Upgrades"]
    if type(upgrades) == "table" then
        for i, tier in ipairs(upgrades) do
            if type(tier) == "table" then
                local delta = sum_fields(tier, fields)
                if delta then
                    running = (running or 0) + delta
                    table.insert(segments, running .. "% (T" .. i .. ")")
                end
            end
        end
    end
    if #segments == 0 then return {} end
    return { ["Debuff Resist"] = table.concat(segments, " → ") }
end
end


return p
return p