Module:AbilityTable: Difference between revisionsGive feedback
refactor abilitytable to use submodules |
grouped repeated hero cells with rowspan |
||
| (17 intermediate revisions by 5 users not shown) | |||
| Line 7: | Line 7: | ||
local p = {} | local p = {} | ||
local extra_columns = { | local extra_columns = { | ||
["barrier"] = { | |||
headers = { "Barrier" }, | |||
get_cells = Renderers.RenderBarrier, | |||
}, | |||
["charges"] = { | ["charges"] = { | ||
headers = { "Charges", "Time Between Charges", "Notes" }, | headers = { "Charges", "Time Between Charges", "Notes" }, | ||
| Line 20: | Line 18: | ||
}, | }, | ||
["melee"] = { | ["melee"] = { | ||
headers = { "Light Melee Scaling", "Notes" }, | headers = { "Base Damage", "Light Melee Scaling", "Notes" }, | ||
get_cells = Renderers.RenderMelee, | get_cells = Renderers.RenderMelee, | ||
}, | |||
["heavymelee"] = { | |||
headers = { "Base Damage", "Heavy Melee Scaling", "Notes" }, | |||
get_cells = Renderers.RenderHeavyMelee, | |||
}, | |||
["scalingspirit"] = { | |||
headers = { "Spirit Scaling", "Notes" }, | |||
get_cells = Renderers.RenderSpiritScaling, | |||
}, | }, | ||
["healreduce"] = { | ["healreduce"] = { | ||
headers = { "Heal Reduction", "Notes" }, | headers = { "Heal Reduction", "Notes" }, | ||
get_cells = Renderers.RenderHealReduce, | get_cells = Renderers.RenderHealReduce, | ||
}, | }, | ||
["moveslow"] = { | ["moveslow"] = { | ||
| Line 42: | Line 40: | ||
headers = { "Dash Slow", "Notes" }, | headers = { "Dash Slow", "Notes" }, | ||
get_cells = Renderers.RenderDashSlow, | get_cells = Renderers.RenderDashSlow, | ||
}, | |||
["extradebuffresist"] = { | |||
headers = { "Debuff Resist" }, | |||
get_cells = Renderers.RenderExtraDebuffResist, | |||
}, | }, | ||
} | } | ||
-- ============================================================ | -- ============================================================ | ||
-- | -- Note enrichment | ||
-- ============================================================ | -- ============================================================ | ||
-- | -- Merges auto-generated and human notes for full-table mode. | ||
local function | -- Capitalizes human note, joins with ". ", ensures trailing period. | ||
if | local function enrich_notes_full(extra, human_note) | ||
if human_note then | |||
human_note = human_note:sub(1,1):upper() .. human_note:sub(2) | |||
extra["Notes"] = extra["Notes"] and (extra["Notes"] .. ". " .. human_note) or human_note | |||
end | |||
if extra["Notes"] and extra["Notes"]:sub(-1) ~= "." then | |||
extra["Notes"] = extra["Notes"] .. "." | |||
if | |||
end | end | ||
end | end | ||
-- | -- Merges auto-generated and human notes for compact mode. | ||
-- | -- Decapitalizes human note (skips T{N} prefixes like "T1 slow"), | ||
-- | -- joins with "; ", strips trailing period. | ||
local function enrich_notes_compact(extra, human_note) | |||
local function | if human_note then | ||
local | local first = human_note:sub(1,1) | ||
if first:match("%u") and not human_note:sub(2,2):match("%d") then | |||
human_note = first:lower() .. human_note:sub(2) | |||
end | end | ||
if human_note:sub(-1) == "." then human_note = human_note:sub(1, -2) end | |||
extra["Notes"] = extra["Notes"] and (extra["Notes"] .. "; " .. human_note) or human_note | |||
end | end | ||
end | end | ||
-- ============================================================ | -- ============================================================ | ||
-- | -- Ability views | ||
-- | |||
-- In-game Ability may containe 1 or more records in AbilityData.json | |||
-- Example: Vexing Bolt is 2 records (Launch Bolt + Redirect Bolt). | |||
-- "Ability View" is a main-record + any relevant sub-ability records. | |||
-- ============================================================ | -- ============================================================ | ||
local | local _views = nil -- card key -> { view = record, heroName = ..., abilityNum = ... } | ||
local | local _order = nil -- array of card keys, sorted by hero then slot | ||
local function | local function build_views() | ||
if | if _views then return _views, _order end | ||
_views, _order = {}, {} | |||
local hero_data = mw.loadJsonData("Data:HeroData.json") | local hero_data = mw.loadJsonData("Data:HeroData.json") | ||
| Line 127: | Line 105: | ||
end | end | ||
local cards = mw.loadJsonData("Data:AbilityCards.json") | local ability_data = mw.loadJsonData(GameData.Dataset.ABILITIES) | ||
local cards = mw.loadJsonData("Data:AbilityCards.json") | |||
local card_of = {} | |||
for _, hero_entry in pairs(cards) do | for _, hero_entry in pairs(cards) do | ||
if type(hero_entry) == "table" then | if type(hero_entry) == "table" then | ||
| Line 134: | Line 115: | ||
for slot_str, ability in pairs(hero_entry) do | for slot_str, ability in pairs(hero_entry) do | ||
local slot_num = tonumber(slot_str) | local slot_num = tonumber(slot_str) | ||
local key = type(ability) == "table" and ability["Key"] or nil | |||
if slot_num and key and ability_data[key] then | |||
card_of[key] = { heroName = hero_name, abilityNum = slot_num } | |||
end | end | ||
end | end | ||
| Line 148: | Line 124: | ||
end | end | ||
return | -- Attach each non-card record to the longest card key it prefixes. | ||
local subs = {} | |||
for key, record in pairs(ability_data) do | |||
if not card_of[key] and record["IsDisabled"] ~= true then | |||
local parent = nil | |||
for card_key in pairs(card_of) do | |||
if key:sub(1, #card_key + 1) == card_key .. "_" | |||
and (parent == nil or #card_key > #parent) | |||
then | |||
parent = card_key | |||
end | |||
end | |||
if parent then | |||
subs[parent] = subs[parent] or {} | |||
table.insert(subs[parent], record) | |||
end | |||
end | |||
end | |||
for key, info in pairs(card_of) do | |||
local view = {} | |||
for k, v in pairs(ability_data[key]) do view[k] = v end | |||
view["_subabilities"] = subs[key] | |||
_views[key] = { view = view, heroName = info.heroName, abilityNum = info.abilityNum } | |||
table.insert(_order, key) | |||
end | |||
table.sort(_order, function(a, b) | |||
local ia, ib = _views[a], _views[b] | |||
if ia.heroName ~= ib.heroName then return ia.heroName < ib.heroName end | |||
return ia.abilityNum < ib.abilityNum | |||
end) | |||
return _views, _order | |||
end | |||
-- ============================================================ | |||
-- Membership | |||
-- Pieces of code that help in telling "is ability X a member of list Y". | |||
-- main function is: p.is_member() | |||
-- ============================================================ | |||
-- Memoized name-exclusion set per list (from Lists.exclude_abilities). | |||
local _excluded = {} | |||
local function excluded_set(stat) | |||
if _excluded[stat] then return _excluded[stat] end | |||
local set = {} | |||
for _, name in ipairs(Lists.exclude_abilities[stat] or {}) do | |||
set[name] = true | |||
end | |||
_excluded[stat] = set | |||
return set | |||
end | |||
-- Per-list rules that can't be expressed as prop lists or exclusions. | |||
-- Returns true to keep the ability, false to drop it. | |||
local function special_ok(stat, record, ability_num) | |||
if stat == "dispelmagic" and ability_num == 4 then return false end | |||
return true | |||
end | |||
-- Public: does ability `ability_key` belong to list `stat`? | |||
function p.is_member(stat, ability_key, ability_num) | |||
local props = Lists.lists[stat] | |||
if not props then return false end | |||
local views = build_views() | |||
local entry = views[ability_key] | |||
local view = entry and entry.view | |||
if not view then | |||
view = mw.loadJsonData(GameData.Dataset.ABILITIES)[ability_key] | |||
if not view then return false end | |||
end | |||
local name = view["Name"] | |||
if name and excluded_set(stat)[name] then return false end | |||
ability_num = ability_num or (entry and entry.abilityNum) | |||
if not special_ok(stat, view, ability_num) then return false end | |||
return GameData.entity_matches(view, props) | |||
end | end | ||
| Line 171: | Line 228: | ||
local compact = mw.text.trim(frame.args["compact"] or "") ~= "" | local compact = mw.text.trim(frame.args["compact"] or "") ~= "" | ||
local | local collapsed = mw.text.trim(frame.args["collapsed"] or ""):lower() | ||
local views, order = build_views() | |||
local spec = extra_columns[stat] | local spec = extra_columns[stat] | ||
local headers = spec and spec.headers or {} | local headers = spec and spec.headers or {} | ||
| Line 177: | Line 236: | ||
local stat_notes = Notes[stat] | local stat_notes = Notes[stat] | ||
local | local filtered = {} | ||
for _, key in ipairs(order) do | |||
if p.is_member(stat, key) then | |||
table.insert(filtered, key) | |||
end | |||
end | |||
if #filtered == 0 then | if #filtered == 0 then | ||
| Line 184: | Line 247: | ||
end | end | ||
local lists_url = mw.uri.fullUrl("Module:AbilityTable/Lists") | |||
local notes_url = mw.uri.fullUrl("Module:AbilityTable/Notes", { action = "edit" }) | |||
local | |||
local disclaimer = frame:preprocess( | local disclaimer = frame:preprocess( | ||
'<div class="ability-table-disclaimer">' | '<div class="ability-table-disclaimer">' | ||
.. | .. 'This is a dynamic list ' | ||
.. | .. '<span class="ability-table-list-name">"' .. stat .. '"</span>. ' | ||
.. | .. '[' .. tostring(lists_url) .. ' Edit contents]' | ||
.. | .. ' · ' | ||
.. '[' .. tostring(notes_url) .. ' Edit notes].' | |||
.. '</div>' | |||
) | ) | ||
| Line 206: | Line 262: | ||
local hero_order = {} | local hero_order = {} | ||
local hero_abilities = {} | local hero_abilities = {} | ||
for _, | for _, key in ipairs(filtered) do | ||
local | local hero = views[key].heroName | ||
if not hero_abilities[hero] then | if not hero_abilities[hero] then | ||
table.insert(hero_order, hero) | table.insert(hero_order, hero) | ||
hero_abilities[hero] = {} | hero_abilities[hero] = {} | ||
end | end | ||
table.insert(hero_abilities[hero], | table.insert(hero_abilities[hero], views[key].view) | ||
end | end | ||
| Line 225: | Line 280: | ||
local extra = get_cells(ability) | local extra = get_cells(ability) | ||
enrich_notes_compact(extra, stat_notes and stat_notes[name]) | |||
local note = extra["Notes"] | local note = extra["Notes"] | ||
| Line 254: | Line 306: | ||
local needs_notes = (has_notes_header or stat_notes ~= nil) and not hide_set["Notes"] | local needs_notes = (has_notes_header or stat_notes ~= nil) and not hide_set["Notes"] | ||
if needs_notes then table.insert(final_headers, "Notes") end | if needs_notes then table.insert(final_headers, "Notes") end | ||
local table_class = 'wikitable sortable ability-table' | |||
if collapsed ~= "" then | |||
table_class = table_class .. ' mw-collapsible' | |||
if collapsed == "yes" or collapsed == "true" or collapsed == "1" then | |||
table_class = table_class .. ' mw-collapsed' | |||
end | |||
end | |||
local out = {} | local out = {} | ||
table.insert(out, disclaimer) | table.insert(out, disclaimer) | ||
table.insert(out, '{| class=" | table.insert(out, '{| class="' .. table_class .. '"') | ||
local header_row = '! class="ability-table-col-hero" | Hero' | local header_row = '! class="ability-table-col-hero" | Hero' | ||
| Line 267: | Line 327: | ||
table.insert(out, header_row) | table.insert(out, header_row) | ||
for _, | local hero_counts = {} | ||
local | for _, key in ipairs(filtered) do | ||
local hero = views[key].heroName | |||
hero_counts[hero] = (hero_counts[hero] or 0) + 1 | |||
end | |||
local hero_seen = {} | |||
local | for _, key in ipairs(filtered) do | ||
local entry = views[key] | |||
local ability = entry.view | |||
local hero = entry.heroName | |||
local ability_cell = frame:expandTemplate{ | |||
local ability_cell = frame:expandTemplate{ title = "AbilityIcon", args = { ability["Name"] } } | title = "AbilityIcon", | ||
args = { ability["Name"] } | |||
} | |||
local extra = get_cells(ability) | local extra = get_cells(ability) | ||
enrich_notes_full(extra, stat_notes and stat_notes[ability["Name"]]) | |||
if | local row | ||
local | |||
if not hero_seen[hero] then | |||
local hero_cell = frame:expandTemplate{ | |||
title = "HeroIcon", | |||
args = { hero } | |||
} | |||
if hero_counts[hero] > 1 then | |||
row = '| rowspan="' .. hero_counts[hero] .. '" class="ability-table-cell-hero" | ' | |||
.. hero_cell | |||
.. ' || class="ability-table-cell-ability" | ' .. ability_cell | |||
else | |||
row = '| class="ability-table-cell-hero" | ' | |||
.. hero_cell | |||
.. ' || class="ability-table-cell-ability" | ' .. ability_cell | |||
end | |||
hero_seen[hero] = true | |||
else | |||
row = '| class="ability-table-cell-ability" | ' .. ability_cell | |||
end | end | ||
for _, header in ipairs(final_headers) do | for _, header in ipairs(final_headers) do | ||
local value = extra[header] | local value = extra[header] | ||