Module:AbilityTable: Difference between revisions

Remove CC_PROPS duplication; derive ordered prop list from debuff_prop_to_effect keys at load time (with help from vergir-bot LLM)
grouped repeated hero cells with rowspan
 
(76 intermediate revisions by 7 users not shown)
Line 1: Line 1:
-- Renders sortable wikitables of abilities filtered by a named stat.
-- Renders sortable wikitables of abilities filtered by a named stat.


-- Maps lowercase friendly stat names to internal AbilityData property keys or values.
local Lists     = require("Module:AbilityTable/Lists")
local stat_to_props = {
local Notes     = require("Module:AbilityTable/Notes")
     ["charges"]    = { "AbilityCharges" },
local Renderers = require("Module:AbilityTable/ComplexRenderers")
     ["melee"]      = { "melee", "heavy_melee" },
local GameData  = require("Module:GameData")
    ["wpndmg"]    = { "melee", "heavy_melee", "weapon_damage_increase" },
 
    ["healreduce"] = { "HealAmpReceivePenaltyPercent", "HealAmpRegenPenaltyPercent", "DisableHealing" },
local p = {}
     ["debuff"]     = {
 
         "StunDuration", "SleepDuration", "SilenceDuration", "SilenceDebuff",
local extra_columns = {
         "PetrifyDuration", "HexDuration", "ImmobilizeDuration", "LiftDuration",
     ["barrier"] = {
        "SlowPercent", "DebuffDuration", "HoldInPlaceDuration",
         headers  = { "Barrier" },
        "DebuffAccuracy", "TimeSlowDuration", "LateCheckoutStun",
         get_cells = Renderers.RenderBarrier,
     },
     },
}
-- Editor-authored notes appended to the Notes column.
local human_notes = {
     ["charges"] = {
     ["charges"] = {
         ["Jar of Dead"]  = "Charges by being near when anything dies.",
         headers  = { "Charges", "Time Between Charges", "Notes" },
        get_cells = Renderers.RenderCharges,
     },
     },
     ["melee"] = {
     ["melee"] = {
         ["Puddle Punch"] = "Can be parried.",
         headers  = { "Base Damage", "Light Melee Scaling", "Notes" },
        get_cells = Renderers.RenderMelee,
    },
    ["heavymelee"] = {
        headers  = { "Base Damage", "Heavy Melee Scaling", "Notes" },
        get_cells = Renderers.RenderHeavyMelee,
    },
    ["scalingspirit"] = {
        headers  = { "Spirit Scaling", "Notes" },
        get_cells = Renderers.RenderSpiritScaling,
    },
    ["healreduce"] = {
        headers  = { "Heal Reduction", "Notes" },
        get_cells = Renderers.RenderHealReduce,
    },
    ["moveslow"] = {
        headers  = { "Move Slow", "Notes" },
        get_cells = Renderers.RenderMoveSlow,
    },
    ["dashslow"] = {
        headers  = { "Dash Slow", "Notes" },
        get_cells = Renderers.RenderDashSlow,
     },
     },
}
     ["extradebuffresist"] = {
 
         headers  = { "Debuff Resist" },
-- Manually specified entries for abilities whose effects cannot be inferred from
         get_cells = Renderers.RenderExtraDebuffResist,
-- data alone (e.g. engine-side CC with no matching data fields).
-- The hero is resolved automatically from AbilityCards.json via the ability name.
-- Each entry requires:
--  effects  = { "EffectName", ... }  (supports "Effect (TN)" for upgrade-only)
--  duration = <number or nil>        (nil renders as "—")
local manual_entries = {
     ["debuff"] = {
         ["Combo"] = {
            effects  = { "Stun" },
            duration = 2.4,
        },
        ["Sand Blast"] = {
            effects  = { "Disarm" },
            duration = 2.5,
         },
        ["Spirit Lasso"] = {
            effects  = { "Stun" },
            duration = 2.25,
        },
     },
     },
}
}
-- Unit strings appended to cell values by column name.
-- Values starting with "(" are treated as already-complete strings and
-- the suffix is NOT appended (e.g. "(See notes)" stays as-is).
local column_suffix = {
    ["Time Between Charges"] = "s",
    ["Duration"]            = "s",
}
-- Actual code below
local p = {}
local GameData = require("Module:GameData")


-- ============================================================
-- ============================================================
-- Shared helpers
-- Note enrichment
-- ============================================================
-- ============================================================


local function num_val(v)
-- Merges auto-generated and human notes for full-table mode.
     if type(v) == "number" then return v end
-- Capitalizes human note, joins with ". ", ensures trailing period.
     if type(v) == "table" then return v["Value"] end
local function enrich_notes_full(extra, human_note)
     return nil
     if human_note then
        human_note = human_note:sub(1,1):upper() .. human_note:sub(2)
        extra["Notes"] = extra["Notes"] and (extra["Notes"] .. ". " .. human_note) or human_note
    end
     if extra["Notes"] and extra["Notes"]:sub(-1) ~= "." then
        extra["Notes"] = extra["Notes"] .. "."
     end
end
end


-- Searches Upgrades[] for a field and returns { tier = N, value = V } at its
-- Merges auto-generated and human notes for compact mode.
-- first appearance, or nil if the field is absent from all upgrade tiers.
-- Decapitalizes human note (skips T{N} prefixes like "T1 slow"),
local function find_in_upgrades(ability, field)
-- joins with "; ", strips trailing period.
     local upgrades = ability["Upgrades"]
local function enrich_notes_compact(extra, human_note)
    if type(upgrades) ~= "table" then return nil end
     if human_note then
    for i, tier in ipairs(upgrades) do
        local first = human_note:sub(1,1)
        if type(tier) == "table" and tier[field] ~= nil then
        if first:match("%u") and not human_note:sub(2,2):match("%d") then
             return { tier = i, value = num_val(tier[field]) }
             human_note = first:lower() .. human_note:sub(2)
         end
         end
        if human_note:sub(-1) == "." then human_note = human_note:sub(1, -2) end
        extra["Notes"] = extra["Notes"] and (extra["Notes"] .. "; " .. human_note) or human_note
     end
     end
    return nil
end
end


-- ============================================================
-- ============================================================
-- Per-stat cell renderers
-- Ability views
-- Each function receives a guaranteed-matching ability record
--
-- and returns { ["Column Name"] = value }.
-- In-game Ability may containe 1 or more records in AbilityData.json
-- Human notes are appended by the framework, not here.
-- Example: Vexing Bolt is 2 records (Launch Bolt + Redirect Bolt).
 
-- "Ability View" is a main-record + any relevant sub-ability records.
-- ============================================================
-- ============================================================


local function charges_cells(ability)
local _views = nil  -- card key -> { view = record, heroName = ..., abilityNum = ... }
    local base_charges  = num_val(ability["AbilityCharges"])
local _order = nil  -- array of card keys, sorted by hero then slot
    local base_cooldown = ability["AbilityCooldownBetweenCharge"]
    local has_base      = base_charges ~= nil and base_charges > 0
    local upgrade_info  = find_in_upgrades(ability, "AbilityCharges")


    local cooldown, upgrade_cooldown
local function build_views()
     if has_base then
     if _views then return _views, _order end
        if type(base_cooldown) == "number" and base_cooldown > 0 then
     _views, _order = {}, {}
            cooldown = base_cooldown
        else
            local cd = find_in_upgrades(ability, "AbilityCooldownBetweenCharge")
            if cd and cd.value and cd.value > 0 then cooldown = cd.value end
        end
     else
        local cd = find_in_upgrades(ability, "AbilityCooldownBetweenCharge")
        if cd and cd.value and cd.value > 0 then upgrade_cooldown = cd.value end
    end


     local cells = {}
     local hero_data = mw.loadJsonData("Data:HeroData.json")
 
    local active_heroes = {}
    if has_base then
    for _, hero in pairs(hero_data) do
        cells["Charges"] = tostring(base_charges)
        if type(hero) == "table"
         if cooldown then
            and hero["IsDisabled"] == false
             cells["Time Between Charges"] = tostring(cooldown)
            and type(hero["Name"]) == "string"
            and (hero["IsSelectable"] == nil or hero["IsSelectable"] ~= false)
         then
             active_heroes[hero["Name"]] = true
         end
         end
     end
     end


     local note_parts = {}
     local ability_data = mw.loadJsonData(GameData.Dataset.ABILITIES)
    if upgrade_info then
    local cards        = mw.loadJsonData("Data:AbilityCards.json")
        local n = upgrade_info.value or "?"
        local charge_str = n .. " charge" .. (n ~= 1 and "s" or "")
        if has_base then
            table.insert(note_parts, "+" .. charge_str .. " on T" .. upgrade_info.tier .. " upgrade.")
        else
            local cd_str = upgrade_cooldown and (upgrade_cooldown .. "s") or "unknown"
            table.insert(note_parts, "Becomes charged on T" .. upgrade_info.tier
                .. " upgrade with " .. charge_str
                .. " and " .. cd_str .. " time between charges.")
        end
    end
    if ability["AbilityChargesConditionally"] ~= nil then
        table.insert(note_parts, "Has a conditional charge.")
    end
    if #note_parts > 0 then
        cells["Notes"] = table.concat(note_parts, " ")
    end


     return cells
     local card_of = {}
end
     for _, hero_entry in pairs(cards) do
 
         if type(hero_entry) == "table" then
local function find_base_melee_scale(ability)
             local hero_name = hero_entry["Name"]
     for _, v in pairs(ability) do
             if hero_name and active_heroes[hero_name] then
         if type(v) == "table" then
                 for slot_str, ability in pairs(hero_entry) do
             local scale = v["Scale"]
                    local slot_num = tonumber(slot_str)
             if type(scale) == "table"
                    local key = type(ability) == "table" and ability["Key"] or nil
                and scale["Type"] == "melee"
                     if slot_num and key and ability_data[key] then
                and type(scale["Value"]) == "number"
                         card_of[key] = { heroName = hero_name, abilityNum = slot_num }
                and scale["Value"] > 0
            then
                 return scale["Value"]
            end
        end
    end
    return nil
end
 
local function build_melee_upgrade_notes(ability, base_melee_scale)
    local upgrades = ability["Upgrades"]
    if type(upgrades) ~= "table" then return {} end
    local notes = {}
    for i, tier in ipairs(upgrades) do
        if type(tier) == "table" then
            for _, v in pairs(tier) do
                if type(v) == "table" then
                    local scale = v["Scale"]
                     if type(scale) == "table" and type(scale["Value"]) == "number" then
                         local stype = scale["Type"]
                        local delta = scale["Value"]
                        if stype == "heavy_melee" and delta > 0 then
                            table.insert(notes, "T" .. i .. " upgrade changes scaling to ×"
                                .. delta .. " of Heavy Melee damage.")
                        elseif stype == "melee" and delta ~= 0 and base_melee_scale then
                            local final = math.floor((base_melee_scale + delta) * 1000 + 0.5) / 1000
                            table.insert(notes, "T" .. i .. " upgrade adds ×"
                                .. delta .. " scaling (total ×" .. final .. ").")
                        end
                     end
                     end
                 end
                 end
Line 183: Line 123:
         end
         end
     end
     end
    return notes
end
local function melee_cells(ability)
    local cells = {}
    local base_scale = find_base_melee_scale(ability)
    if base_scale then cells["Light Melee Scaling"] = "×" .. base_scale end
    local upgrade_notes = build_melee_upgrade_notes(ability, base_scale)
    if #upgrade_notes > 0 then cells["Notes"] = table.concat(upgrade_notes, " ") end
    return cells
end


local function find_base_duration(ability)
     -- Attach each non-card record to the longest card key it prefixes.
     for _, field in ipairs({ "VenomDuration", "DebuffDuration", "AbilityDuration", "BurnDuration" }) do
     local subs = {}
        local v = num_val(ability[field])
     for key, record in pairs(ability_data) do
        if v and v > 0 then return v, field end
        if not card_of[key] and record["IsDisabled"] ~= true then
    end
            local parent = nil
     return nil, nil
             for card_key in pairs(card_of) do
end
                 if key:sub(1, #card_key + 1) == card_key .. "_"
 
                     and (parent == nil or #card_key > #parent)
local function healreduce_cells(ability)
                then
    local cells = {}
                     parent = card_key
     local notes = {}
    local base_dur, dur_field = find_base_duration(ability)
 
    local first_pct, first_tier, first_is_disable = nil, nil, false
    local base_receive = num_val(ability["HealAmpReceivePenaltyPercent"])
    local base_regen  = num_val(ability["HealAmpRegenPenaltyPercent"])
    local base_pct_raw = base_receive or base_regen
    if base_pct_raw and base_pct_raw ~= 0 then
        first_pct = math.abs(base_pct_raw)
    elseif ability["DisableHealing"] and ability["DisableHealing"] ~= 0 then
        first_is_disable = true
    else
        local upgrades = ability["Upgrades"]
        if type(upgrades) == "table" then
             for i, tier in ipairs(upgrades) do
                 if type(tier) == "table" then
                     local up_raw = num_val(tier["HealAmpReceivePenaltyPercent"])
                                or num_val(tier["HealAmpRegenPenaltyPercent"])
                    if up_raw and up_raw ~= 0 then
                        first_pct, first_tier = math.abs(up_raw), i
                        break
                     elseif tier["DisableHealing"] and tier["DisableHealing"] ~= 0 then
                        first_is_disable, first_tier = true, i
                        break
                    end
                 end
                 end
            end
            if parent then
                subs[parent] = subs[parent] or {}
                table.insert(subs[parent], record)
             end
             end
         end
         end
     end
     end


     if first_is_disable then
     for key, info in pairs(card_of) do
         cells["Heal Reduction"] = "100%" .. (first_tier and " (T" .. first_tier .. ")" or "")
        local view = {}
    elseif first_pct then
         for k, v in pairs(ability_data[key]) do view[k] = v end
         cells["Heal Reduction"] = tostring(first_pct) .. "%" .. (first_tier and " (T" .. first_tier .. ")" or "")
        view["_subabilities"] = subs[key]
         _views[key] = { view = view, heroName = info.heroName, abilityNum = info.abilityNum }
        table.insert(_order, key)
     end
     end
    if base_dur then cells["Duration"] = tostring(base_dur) end


     local upgrades = ability["Upgrades"]
     table.sort(_order, function(a, b)
    if type(upgrades) == "table" then
         local ia, ib = _views[a], _views[b]
        local running_pct, running_dur = first_pct, base_dur
        if ia.heroName ~= ib.heroName then return ia.heroName < ib.heroName end
         local first_pct_seen = (first_tier == nil)
        return ia.abilityNum < ib.abilityNum
        for i, tier in ipairs(upgrades) do
    end)
            if type(tier) == "table" then
                local tier_notes = {}
                local pct_delta = num_val(tier["HealAmpReceivePenaltyPercent"])
                              or num_val(tier["HealAmpRegenPenaltyPercent"])
                if first_tier == i then
                    first_pct_seen = true
                    if first_pct then running_pct = first_pct end
                elseif first_pct_seen and pct_delta and pct_delta ~= 0 then
                    local delta_abs = math.abs(pct_delta)
                    local total = (running_pct or 0) + delta_abs
                    table.insert(tier_notes, "T" .. i .. " upgrade increases heal reduction by "
                        .. delta_abs .. "% (total " .. total .. "%).")
                    running_pct = total
                end
                if dur_field then
                    local dur_delta = num_val(tier[dur_field])
                    if dur_delta and dur_delta ~= 0 and running_dur then
                        local total_dur = running_dur + dur_delta
                        table.insert(tier_notes, "T" .. i .. " upgrade "
                            .. (dur_delta > 0 and "increases" or "decreases")
                            .. " duration by " .. math.abs(dur_delta)
                            .. "s (total " .. total_dur .. "s).")
                        running_dur = total_dur
                    end
                end
                for _, n in ipairs(tier_notes) do table.insert(notes, n) end
            end
        end
    end


     if #notes > 0 then cells["Notes"] = table.concat(notes, " ") end
     return _views, _order
    return cells
end
end


-- Maps AbilityData property names to human-readable effect names for the debuff table.
-- ============================================================
-- Ordered list ensures deterministic effect output; pairs() iteration order is not guaranteed.
-- Membership
-- DebuffDuration is absent: it signals "(See notes)" on Duration rather than a named effect.
-- Pieces of code that help in telling  "is ability X a member of list Y".
local debuff_prop_to_effect = {
-- main function is: p.is_member()
    StunDuration        = "Stun",
-- ============================================================
    SleepDuration      = "Sleep",
    SilenceDuration    = "Silence",
    SilenceDebuff      = "Silence",
    PetrifyDuration    = "Petrify",
    HexDuration        = "Hex",
    ImmobilizeDuration  = "Root",
    LiftDuration        = "Lift",
    SlowPercent        = "Slow",
    HoldInPlaceDuration = "Stop",
    DebuffAccuracy      = "Inaccuracy",
    TimeSlowDuration    = "Time Slow",
    LateCheckoutStun    = "Stun",
}
 
-- Ordered list of keys from debuff_prop_to_effect, used to iterate props deterministically.
local debuff_props_ordered = {
    "StunDuration", "SleepDuration", "SilenceDuration", "SilenceDebuff",
    "PetrifyDuration", "HexDuration", "ImmobilizeDuration", "LiftDuration",
    "SlowPercent", "HoldInPlaceDuration", "DebuffAccuracy",
    "TimeSlowDuration", "LateCheckoutStun",
}


local function debuff_cells(ability, stat_manual)
-- Memoized name-exclusion set per list (from Lists.exclude_abilities).
    local cells = {}
local _excluded = {}
 
local function excluded_set(stat)
     -- Manual entry takes full precedence.
     if _excluded[stat] then return _excluded[stat] end
     local manual = stat_manual and stat_manual[ability["Name"]]
     local set = {}
     if manual then
     for _, name in ipairs(Lists.exclude_abilities[stat] or {}) do
        if manual.effects and #manual.effects > 0 then
         set[name] = true
            cells["Effects"] = table.concat(manual.effects, ", ")
         end
        if manual.duration then
            cells["Duration"] = tostring(manual.duration)
        end
        return cells
     end
     end
    _excluded[stat] = set
    return set
end


    local effects_seen = {}  -- ordered list of { name, tier }
-- Per-list rules that can't be expressed as prop lists or exclusions.
     local effects_set  = {}  -- effect name -> true, for dedup
-- Returns true to keep the ability, false to drop it.
local function special_ok(stat, record, ability_num)
     if stat == "dispelmagic" and ability_num == 4 then return false end
    return true
end


    local function collect_effects(obj, tier)
-- Public: does ability `ability_key` belong to list `stat`?
        for _, prop in ipairs(debuff_props_ordered) do
function p.is_member(stat, ability_key, ability_num)
            local val    = obj[prop]
    local props = Lists.lists[stat]
            local effect = debuff_prop_to_effect[prop]
    if not props then return false end
            if val and val ~= 0 and effect and not effects_set[effect] then
                table.insert(effects_seen, { name = effect, tier = tier })
                effects_set[effect] = true
            end
        end
    end


     collect_effects(ability, nil)
     local views = build_views()
     local upgrades = ability["Upgrades"]
     local entry = views[ability_key]
     if type(upgrades) == "table" then
     local view  = entry and entry.view
        for i, tier in ipairs(upgrades) do
            if type(tier) == "table" then
                collect_effects(tier, i)
            end
        end
    end


    -- DebuffDuration: present anywhere → Duration shows "(See notes)"
     if not view then
    local has_debuff_dur = (ability["DebuffDuration"] and ability["DebuffDuration"] ~= 0)
         view = mw.loadJsonData(GameData.Dataset.ABILITIES)[ability_key]
     if not has_debuff_dur and type(upgrades) == "table" then
         if not view then return false end
         for _, tier in ipairs(upgrades) do
            if type(tier) == "table" and tier["DebuffDuration"] and tier["DebuffDuration"] ~= 0 then
                has_debuff_dur = true
                break
            end
         end
     end
     end


    -- Effects cell
     local name = view["Name"]
     local effect_parts = {}
     if name and excluded_set(stat)[name] then return false end
     for _, e in ipairs(effects_seen) do
        table.insert(effect_parts, e.tier and (e.name .. " (T" .. e.tier .. ")") or e.name)
    end
    if #effect_parts > 0 then
        cells["Effects"] = table.concat(effect_parts, ", ")
    end


     -- Duration cell: collect distinct non-DebuffDuration duration fields (base or upgrade).
     ability_num = ability_num or (entry and entry.abilityNum)
    -- If exactly one found → use its value. If multiple, or DebuffDuration present → "(See notes)".
     if not special_ok(stat, view, ability_num) then return false end
    local DUR_FIELDS = {
        "StunDuration", "SleepDuration", "SilenceDuration", "PetrifyDuration",
        "HexDuration", "ImmobilizeDuration", "LiftDuration", "SlowDuration",
        "HoldInPlaceDuration", "AbilityDuration", "TimeSlowDuration", "LateCheckoutStun",
    }
    local dur_found = {}
    local function collect_durations(obj)
        for _, f in ipairs(DUR_FIELDS) do
            if not dur_found[f] then
                local val = num_val(obj[f])
                if val and val > 0 then dur_found[f] = val end
            end
        end
    end
 
    collect_durations(ability)
    if type(upgrades) == "table" then
        for _, tier in ipairs(upgrades) do
            if type(tier) == "table" then collect_durations(tier) end
        end
    end
 
    -- AbilityDuration is only meaningful when DebuffAccuracy is the sole CC prop (Call Bell).
    local sole_cc_is_accuracy = (effects_set["Inaccuracy"] and not effects_set["Slow"]
        and not effects_set["Stun"] and not effects_set["Sleep"]
        and not effects_set["Silence"] and not effects_set["Petrify"]
        and not effects_set["Hex"] and not effects_set["Root"]
        and not effects_set["Lift"] and not effects_set["Stop"]
        and not effects_set["Time Slow"])
     if not sole_cc_is_accuracy then
        dur_found["AbilityDuration"] = nil
    end
 
    local count, sole_val = 0, nil
    for _, val in pairs(dur_found) do count = count + 1; sole_val = val end
 
    if count == 1 then
        cells["Duration"] = tostring(sole_val)
    elseif count > 1 or has_debuff_dur then
        cells["Duration"] = "(See notes)"
    end
 
    return cells
end
 
local extra_columns = {
    ["charges"] = {
        headers  = { "Charges", "Time Between Charges", "Notes" },
        get_cells = charges_cells,
    },
    ["melee"] = {
        headers  = { "Light Melee Scaling", "Notes" },
        get_cells = melee_cells,
    },
    ["healreduce"] = {
        headers  = { "Heal Reduction", "Duration", "Notes" },
        get_cells = healreduce_cells,
    },
    ["debuff"] = {
        headers  = { "Effects", "Duration" },
        get_cells = debuff_cells,
    },
}
 
-- ============================================================
-- Name lookup: ability name -> { heroName, abilityNum }
-- Built from HeroData (active hero filter) + AbilityCards.
-- Used for both prop-matched and manual abilities.
-- ============================================================
 
local _name_lookup = nil
 
local function build_name_lookup()
    if _name_lookup then return _name_lookup end
    _name_lookup = {}
 
    local hero_data = mw.loadJsonData("Data:HeroData.json")
    local active_heroes = {}
    for _, hero in pairs(hero_data) do
        if type(hero) == "table"
            and hero["IsDisabled"] == false
            and type(hero["Name"]) == "string"
            and (hero["IsSelectable"] == nil or hero["IsSelectable"] ~= false)
        then
            active_heroes[hero["Name"]] = true
        end
    end
 
    local cards = mw.loadJsonData("Data:AbilityCards.json")
    for _, hero_entry in pairs(cards) do
        if type(hero_entry) == "table" then
            local hero_name = hero_entry["Name"]
            if hero_name and active_heroes[hero_name] then
                for slot_str, ability in pairs(hero_entry) do
                    local slot_num = tonumber(slot_str)
                    if slot_num and type(ability) == "table" and ability["Name"] then
                        _name_lookup[ability["Name"]] = {
                            heroName  = hero_name,
                            abilityNum = slot_num,
                        }
                    end
                end
            end
        end
    end


     return _name_lookup
     return GameData.entity_matches(view, props)
end
end


Line 485: Line 215:
     local stat = mw.text.trim(frame.args[1] or ""):lower()
     local stat = mw.text.trim(frame.args[1] or ""):lower()


     local internal_keys = stat_to_props[stat]
     local internal_keys = Lists.lists[stat]
     if not internal_keys then
     if not internal_keys then
         return '<span class="error">AbilityTable: unknown stat "' .. stat .. '".</span>'
         return '<span class="error">AbilityTable: unknown list "' .. stat .. '".</span>'
     end
     end


Line 496: Line 226:
     end
     end


     local name_lookup = build_name_lookup()
     local compact = mw.text.trim(frame.args["compact"] or "") ~= ""
    local spec        = extra_columns[stat]
 
    local headers    = spec and spec.headers or {}
     local collapsed = mw.text.trim(frame.args["collapsed"] or ""):lower()
    local stat_notes  = human_notes[stat]
     local stat_manual = manual_entries[stat]


     local get_cells
     local views, order = build_views()
     if spec then
     local spec       = extra_columns[stat]
        if stat == "debuff" then
    local headers    = spec and spec.headers or {}
            get_cells = function(ability) return debuff_cells(ability, stat_manual) end
    local get_cells = spec and spec.get_cells or function() return {} end
         else
    local stat_notes = Notes[stat]
             get_cells = spec.get_cells
 
    local filtered = {}
    for _, key in ipairs(order) do
         if p.is_member(stat, key) then
             table.insert(filtered, key)
         end
         end
    else
        get_cells = function() return {} end
     end
     end


     local abilities = GameData.get_entities(GameData.Dataset.ABILITIES, internal_keys)
     if #filtered == 0 then
        return "No abilities found for list: " .. stat
    end


     -- Keep only abilities belonging to active, released heroes
     local lists_url = mw.uri.fullUrl("Module:AbilityTable/Lists")
     local filtered = {}
    local notes_url = mw.uri.fullUrl("Module:AbilityTable/Notes", { action = "edit" })
    local filtered_names = {}
    local disclaimer = frame:preprocess(
    for _, ability in ipairs(abilities) do
        '<div class="ability-table-disclaimer">'
        if ability["Name"] and name_lookup[ability["Name"]] then
        .. 'This is a dynamic list '
            table.insert(filtered, ability)
        .. '<span class="ability-table-list-name">"' .. stat .. '"</span>. '
             filtered_names[ability["Name"]] = true
        .. '[' .. tostring(lists_url) .. ' Edit contents]'
        .. ' · '
        .. '[' .. tostring(notes_url) .. ' Edit notes].'
        .. '</div>'
    )
 
     if compact then
        local hero_order    = {}
        local hero_abilities = {}
        for _, key in ipairs(filtered) do
            local hero = views[key].heroName
            if not hero_abilities[hero] then
                table.insert(hero_order, hero)
                hero_abilities[hero] = {}
             end
            table.insert(hero_abilities[hero], views[key].view)
         end
         end
    end


    -- Inject manual entries not already covered by prop-matching.
        local items = {}
    -- Hero and slot are resolved via name_lookup; if the ability isn't in AbilityCards
        for _, hero in ipairs(hero_order) do
    -- the row shows "" in the Hero column and sorts to the end.
            local hero_cell = frame:expandTemplate{ title = "HeroIcon", args = { hero } }
    if stat_manual then
            local ability_parts = {}
        for name, _ in pairs(stat_manual) do
            for _, ability in ipairs(hero_abilities[hero]) do
            if not filtered_names[name] then
                local name = ability["Name"]
                 table.insert(filtered, { Name = name })
                local ability_cell = frame:expandTemplate{ title = "AbilityIcon", args = { name } }
 
                local extra = get_cells(ability)
                enrich_notes_compact(extra, stat_notes and stat_notes[name])
 
                local note = extra["Notes"]
                if note then
                    table.insert(ability_parts, ability_cell .. " (" .. note .. ")")
                 else
                    table.insert(ability_parts, ability_cell)
                end
             end
             end
            table.insert(items, "<li>" .. hero_cell .. ": " .. table.concat(ability_parts, ", ") .. "</li>")
         end
         end
    end


    if #filtered == 0 then
         return disclaimer .. "<ul>" .. table.concat(items) .. "</ul>"
         return "No abilities found for stat: " .. stat
     end
     end


    -- Sort by hero name, then ability slot number.
    -- Abilities not in name_lookup sort to the end alphabetically.
    table.sort(filtered, function(a, b)
        local ia = name_lookup[a["Name"]]
        local ib = name_lookup[b["Name"]]
        if not ia and not ib then return (a["Name"] or "") < (b["Name"] or "") end
        if not ia then return false end
        if not ib then return true end
        if ia.heroName ~= ib.heroName then return ia.heroName < ib.heroName end
        return ia.abilityNum < ib.abilityNum
    end)
    -- Determine final headers
     local has_notes_header = false
     local has_notes_header = false
     local final_headers = {}
     local final_headers = {}
Line 565: Line 307:
     if needs_notes then table.insert(final_headers, "Notes") end
     if needs_notes then table.insert(final_headers, "Notes") end


     -- Disclaimer
     local table_class = 'wikitable sortable ability-table'
     local edit_url = mw.uri.fullUrl("Module:AbilityTable", { action = "edit" })
     if collapsed ~= "" then
    local disclaimer = frame:preprocess(
        table_class = table_class .. ' mw-collapsible'
        '<div class="ability-table-disclaimer">'
         if collapsed == "yes" or collapsed == "true" or collapsed == "1" then
         .. "This is an automatic list. "
            table_class = table_class .. ' mw-collapsed'
        .. "[" .. tostring(edit_url) .. " Click here]"
         end
        .. " to add notes or correct the contents."
     end
         .. "</div>"
     )


     local out = {}
     local out = {}
     table.insert(out, disclaimer)
     table.insert(out, disclaimer)
     table.insert(out, '{| class="wikitable sortable ability-table"')
     table.insert(out, '{| class="' .. table_class .. '"')


     local header_row = '! class="ability-table-col-hero" | Hero'
     local header_row = '! class="ability-table-col-hero" | Hero'
Line 587: Line 327:
     table.insert(out, header_row)
     table.insert(out, header_row)


     for _, ability in ipairs(filtered) do
        local hero_counts = {}
         local info = name_lookup[ability["Name"]]
     for _, key in ipairs(filtered) do
         local hero = views[key].heroName
        hero_counts[hero] = (hero_counts[hero] or 0) + 1
    end


         local hero_cell
    local hero_seen = {}
         if info then
 
            hero_cell = frame:expandTemplate{ title = "HeroIcon", args = { info.heroName } }
    for _, key in ipairs(filtered) do
         else
         local entry  = views[key]
            hero_cell = "—"
         local ability = entry.view
        end
         local hero    = entry.heroName
         local ability_cell = frame:expandTemplate{ title = "AbilityIcon", args = { ability["Name"] } }
 
         local ability_cell = frame:expandTemplate{
            title = "AbilityIcon",
            args = { ability["Name"] }
        }


         local extra = get_cells(ability)
         local extra = get_cells(ability)
        enrich_notes_full(extra, stat_notes and stat_notes[ability["Name"]])
        local row


         if stat_notes and stat_notes[ability["Name"]] then
         if not hero_seen[hero] then
             local human = stat_notes[ability["Name"]]
             local hero_cell = frame:expandTemplate{
            extra["Notes"] = extra["Notes"] and (extra["Notes"] .. " " .. human) or human
                title = "HeroIcon",
                args = { hero }
            }
 
            if hero_counts[hero] > 1 then
                row = '| rowspan="' .. hero_counts[hero] .. '" class="ability-table-cell-hero" | '
                    .. hero_cell
                    .. ' || class="ability-table-cell-ability" | ' .. ability_cell
            else
                row = '| class="ability-table-cell-hero" | '
                    .. hero_cell
                    .. ' || class="ability-table-cell-ability" | ' .. ability_cell
            end
 
            hero_seen[hero] = true
        else
            row = '| class="ability-table-cell-ability" | ' .. ability_cell
         end
         end


        local row = '| class="ability-table-cell-hero" | '    .. hero_cell
                .. ' || class="ability-table-cell-ability" | ' .. ability_cell
         for _, header in ipairs(final_headers) do
         for _, header in ipairs(final_headers) do
             local value = extra[header]
             local value = extra[header]
             local cls  = "ability-table-cell-" .. header:lower():gsub("%s+", "-")
             local cls  = "ability-table-cell-" .. header:lower():gsub("%s+", "-")
             local content
             local content = value ~= nil and tostring(value) or "—"
            if value ~= nil then
                local suffix = column_suffix[header] or ""
                content = (type(value) == "string" and value:sub(1,1) == "(")
                    and value or (value .. suffix)
            else
                content = "—"
            end
             row = row .. ' || class="' .. cls .. '" | ' .. content
             row = row .. ' || class="' .. cls .. '" | ' .. content
         end
         end