Module:Icon: Difference between revisionsGive feedback
Small fix |
Reverted attempted fix Tag: Manual revert |
||
| Line 4: | Line 4: | ||
local lang_codes = mw.loadJsonData("Data:LangCodes.json") | local lang_codes = mw.loadJsonData("Data:LangCodes.json") | ||
-- Cache for compiled icon data | -- Cache for compiled icon data (persists during page render) | ||
local iconDataCache = nil | |||
local iconDataCache = | |||
local cachedLangCode, cachedLangData | local cachedLangCode, cachedLangData | ||
| Line 29: | Line 25: | ||
} | } | ||
-- Build lookup table from bot-uploaded JSONs | -- Build unified lookup table from bot-uploaded JSONs | ||
local function buildIconData() | |||
local function buildIconData( | if iconDataCache then | ||
-- | return iconDataCache | ||
end | |||
local lookup = {} | |||
-- Load bot data | |||
local heroData = mw.loadJsonData("Data:HeroData.json") | |||
local abilityData = mw.loadJsonData("Data:AbilityData.json") | |||
local itemData = mw.loadJsonData("Data:ItemData.json") | |||
-- Track which hero owns which ability (for linking) | |||
local abilityToHero = {} | |||
-- Process Heroes | |||
for heroKey, hero in pairs(heroData) do | |||
if type(hero) == "table" and hero.Name then | |||
local name = hero.Name | |||
local lowerName = name:lower() | |||
-- Check for missing image override | |||
local imageName = missingImageOverrides[lowerName] or (name .. ".png") | |||
lookup[lowerName] = { | |||
name = name, | |||
key = heroKey, | |||
link = name, | |||
image = imageName, | |||
type = "hero" | |||
} | |||
-- Map abilities to parent hero | |||
if hero.BoundAbilities then | |||
if | |||
for slot, ability in pairs(hero.BoundAbilities) do | for slot, ability in pairs(hero.BoundAbilities) do | ||
if ability.Key then | if ability.Key then | ||
abilityToHero[ability.Key] = { | abilityToHero[ability.Key] = { | ||
heroName = | heroName = name, | ||
abilityName = ability.Name | abilityName = ability.Name | ||
} | } | ||
| Line 77: | Line 70: | ||
end | end | ||
end | end | ||
end | |||
-- Process Abilities | |||
for abilityKey, ability in pairs(abilityData) do | |||
if type(ability) == "table" and ability.Name then | |||
local name = ability.Name | |||
local lowerName = name:lower() | |||
local parentInfo = abilityToHero[abilityKey] | |||
-- If we already have this ability name, prefer the one linked to a hero | |||
if lookup[lowerName] and lookup[lowerName].type == "ability" then | |||
local existingHasParent = lookup[lowerName].link ~= lookup[lowerName].name | |||
local newHasParent = parentInfo ~= nil | |||
-- Skip if existing is linked to hero but this one isn't (prevents orphans from overwriting real ones) | |||
if existingHasParent and not newHasParent then | |||
-- Skip this orphan ability | |||
else | else | ||
-- | -- Overwrite: new has parent and existing doesn't, or both/neither have parents | ||
local link = parentInfo and parentInfo.heroName or name | local link = parentInfo and parentInfo.heroName or name | ||
lookup[lowerName] = { | |||
name = name, | name = name, | ||
key = abilityKey, | key = abilityKey, | ||
| Line 117: | Line 99: | ||
} | } | ||
end | end | ||
else | |||
-- No existing entry, add normally | |||
local link = parentInfo and parentInfo.heroName or name | |||
lookup[lowerName] = { | |||
local | |||
name = name, | name = name, | ||
key = | key = abilityKey, | ||
link = | link = link, | ||
image = name .. ".png", | image = name .. ".png", | ||
type = " | type = "ability", | ||
class = "theme" | |||
} | } | ||
end | end | ||
end | end | ||
end | end | ||
-- Process Items | |||
for itemKey, item in pairs(itemData) do | |||
if type(item) == "table" and item.Name then | |||
local name = item.Name | |||
local lowerName = name:lower() | |||
lookup[lowerName] = { | |||
name = name, | |||
key = itemKey, | |||
link = name, | |||
image = name .. ".png", | |||
type = "item" | |||
} | |||
end | |||
end | |||
iconDataCache = lookup | |||
return lookup | |||
end | end | ||
-- Get icon data by name | -- Get icon data by name (with alias support) | ||
local function getIconData(iconName | local function getIconData(iconName) | ||
buildIconData( | local data = buildIconData() | ||
local lowerName = iconName:lower() | local lowerName = iconName:lower() | ||
-- Check main lookup | -- Check main lookup | ||
if | if data[lowerName] then | ||
return | return data[lowerName], nil | ||
end | end | ||
-- Check aliases (for edge cases like "doorman" -> "the doorman") | -- Check aliases (for edge cases like "doorman" -> "the doorman") | ||
local aliases = { | local aliases = { | ||
| Line 165: | Line 153: | ||
["debuff remover"] = "dispel magic" | ["debuff remover"] = "dispel magic" | ||
} | } | ||
if aliases[lowerName] then | if aliases[lowerName] then | ||
return data[aliases[lowerName]], nil | |||
end | end | ||
return nil, string.format("[[:Category:Module:Icon ERROR|Icon not found]] ('%s'). [[Category:Module:Icon ERROR]]", iconName) | return nil, string.format("[[:Category:Module:Icon ERROR|Icon not found]] ('%s'). [[Category:Module:Icon ERROR]]", iconName) | ||
end | end | ||
| Line 207: | Line 192: | ||
local name = args[1] or "" | local name = args[1] or "" | ||
local customText = args.l1 or "" | local customText = args.l1 or "" | ||
-- Set Defaults | -- Set Defaults | ||
local size = args.size or "20px" | local size = args.size or "20px" | ||
| Line 219: | Line 202: | ||
if type(k) == "number" and k > 1 then | if type(k) == "number" and k > 1 then | ||
local val = mw.text.trim(v) | local val = mw.text.trim(v) | ||
if val == "icon-only" then | if val == "icon-only" then | ||
iconOnly = true | iconOnly = true | ||
elseif val == "no-link" then | elseif val == "no-link" then | ||
noLink = true | noLink = true | ||
elseif val:match("^%d+px$") then | elseif val:match("^%d+px$") then | ||
size = val | size = val | ||
end | end | ||
| Line 230: | Line 213: | ||
end | end | ||
-- Get icon data automatically from JSON | -- Get icon data automatically from JSON | ||
local iconData, err = getIconData(name | local iconData, err = getIconData(name) | ||
if not iconData then | if not iconData then | ||
return "Error: " .. err | return "Error: " .. err | ||
| Line 237: | Line 220: | ||
local langCode, langData = getLangData() | local langCode, langData = getLangData() | ||
-- Determine display name | -- Determine display name | ||
local displayName = "" | local displayName = "" | ||
| Line 251: | Line 234: | ||
local baseLink = iconData.link or "" | local baseLink = iconData.link or "" | ||
local link = baseLink | local link = baseLink | ||
if langCode ~= "en" and baseLink ~= "" then | if langCode ~= "en" and baseLink ~= "" then | ||
link = baseLink .. "/" .. langCode | link = baseLink .. "/" .. langCode | ||