Module:ItemData/nav - Revision history

Joe Rippa: Undo revision 146582 by Joe Rippa (talk) This is unnecessary for the change I wanted to make

2026-09-10T19:54:35Z

Undo revision 146582 by Joe Rippa (talk) This is unnecessary for the change I wanted to make

← Older revision		Revision as of 19:54, 10 September 2026
Line 316:		Line 316:
	-- Optimized string compilation using a structural buffer table		-- Optimized string compilation using a structural buffer table
	local rows = {}		local rows = {}
	table.insert(rows, [=[{\| class="wikitable mw-collapsible ~~mw-collapsed~~ sortable" style="width:100%"		table.insert(rows, [=[{\| class="wikitable mw-collapsible sortable" style="width:100%"
	\|+{{#invoke:Dictionary\|translate\|Active Items}}		\|+{{#invoke:Dictionary\|translate\|Active Items}}
	! colspan="2" \| {{#invoke:Lang\|get_string\|Citadel_HeroBuilds_CategoryNameLabel}}		! colspan="2" \| {{#invoke:Lang\|get_string\|Citadel_HeroBuilds_CategoryNameLabel}}

Joe Rippa: Making the Active Items template be collapsed by default. This shouldn't affect the other tables but if it does, please revert

2026-09-10T19:07:36Z

Making the Active Items template be collapsed by default. This shouldn't affect the other tables but if it does, please revert

← Older revision		Revision as of 19:07, 10 September 2026
Line 316:		Line 316:
	-- Optimized string compilation using a structural buffer table		-- Optimized string compilation using a structural buffer table
	local rows = {}		local rows = {}
	table.insert(rows, [=[{\| class="wikitable mw-collapsible sortable" style="width:100%"		table.insert(rows, [=[{\| class="wikitable mw-collapsible mw-collapsed sortable" style="width:100%"
	\|+{{#invoke:Dictionary\|translate\|Active Items}}		\|+{{#invoke:Dictionary\|translate\|Active Items}}
	! colspan="2" \| {{#invoke:Lang\|get_string\|Citadel_HeroBuilds_CategoryNameLabel}}		! colspan="2" \| {{#invoke:Lang\|get_string\|Citadel_HeroBuilds_CategoryNameLabel}}

~2026-ReachMidbossStamina753: Update stale LOW_GRAPHICS comment to describe the current cacheable-overlay behavior (with help from vergir-bot LLM)

2026-07-25T00:03:05Z

Update stale LOW_GRAPHICS comment to describe the current cacheable-overlay behavior (with help from vergir-bot LLM)

← Older revision		Revision as of 00:03, 25 July 2026
Line 14:		Line 14:

	-- The card navboxes put every item on a single page, so their cards opt into		-- The card navboxes put every item on a single page, so their cards opt into
	-- the cheaper ItemBox rendering~~: a gradient instead of~~ the ~~masked wear tint, no~~		-- the cheaper ItemBox rendering via lowGraphics. This swaps the paper texture
	-- ~~icon mask, one shared paper,~~ and ~~an icon requested at the size it~~ is ~~actually~~		-- from the normal-mode multiply (which blends two images and is re-rasterised
	-- ~~drawn. Each of those~~ is a ~~render pass~~, ~~a backdrop read or a texture upload~~ the		-- every scrolled frame) to a transparent-paper overlay that is a single
	-- ~~GPU would otherwise repeat for every card on screen~~. See [[Template:ItemBox]].		-- cacheable image, the one change that carried the navbox scroll cost. The wear
	-- Only the ItemBox branch of write_wrapped_item_list uses this; the ItemIcon		-- and icon masks stay at full detail, since a single-image mask caches fine.
	-- lists are unaffected.		-- See [[Template:ItemBox]]. Only the ItemBox branch of write_wrapped_item_list
			-- uses this; the ItemIcon lists are unaffected.
	local LOW_GRAPHICS = "\|lowGraphics=true"		local LOW_GRAPHICS = "\|lowGraphics=true"

~2026-ReachMidbossStamina753: Use the single lowGraphics flag for navbox cards now that ItemBox bundles the cheap layers and the 1x icon request (with help from vergir-bot LLM)

2026-07-24T15:07:03Z

Use the single lowGraphics flag for navbox cards now that ItemBox bundles the cheap layers and the 1x icon request (with help from vergir-bot LLM)

← Older revision		Revision as of 15:07, 24 July 2026
Line 14:		Line 14:

	-- The card navboxes put every item on a single page, so their cards opt into		-- The card navboxes put every item on a single page, so their cards opt into
	-- the cheaper ItemBox ~~layers~~: a gradient instead of the masked wear tint, no		-- the cheaper ItemBox rendering: a gradient instead of the masked wear tint, no
	-- icon mask, ~~and~~ one shared paper ~~instead of one picked per item~~. Each of those		-- icon mask, one shared paper, and an icon requested at the size it is actually
	-- is a render pass or a backdrop read the GPU would otherwise repeat ~~per~~ card.		-- drawn. Each of those is a render pass, a backdrop read or a texture upload the
	-- See ~~the parameters on~~ [[Template:ItemBox]]. Only the ItemBox branch of		-- GPU would otherwise repeat for every card on screen. See [[Template:ItemBox]].
	-- write_wrapped_item_list uses this; the ItemIcon lists are unaffected.		-- Only the ItemBox branch of write_wrapped_item_list uses this; the ItemIcon
	local LOW_GRAPHICS = "\|~~wearMask=ramp\|iconMask=no\|texture~~=3"		-- lists are unaffected.
			local LOW_GRAPHICS = "\|lowGraphics=true"

	-- Cached items grouped by slot to prevent redundant full-table evaluations		-- Cached items grouped by slot to prevent redundant full-table evaluations

Vergir: Render the v2 navbox item cards in low-graphics mode: ramped wear, no icon mask, single paper texture (with help from vergir-bot LLM)

2026-07-24T12:56:12Z

Render the v2 navbox item cards in low-graphics mode: ramped wear, no icon mask, single paper texture (with help from vergir-bot LLM)

← Older revision		Revision as of 12:56, 24 July 2026
Line 1:		Line 1:


	local p = {}		local p = {}
Line 11:		Line 12:
	["Spirit Lifesteal"] = "Spirit Lifesteal (item)"		["Spirit Lifesteal"] = "Spirit Lifesteal (item)"
	}		}

			-- The card navboxes put every item on a single page, so their cards opt into
			-- the cheaper ItemBox layers: a gradient instead of the masked wear tint, no
			-- icon mask, and one shared paper instead of one picked per item. Each of those
			-- is a render pass or a backdrop read the GPU would otherwise repeat per card.
			-- See the parameters on [[Template:ItemBox]]. Only the ItemBox branch of
			-- write_wrapped_item_list uses this; the ItemIcon lists are unaffected.
			local LOW_GRAPHICS = "\|wearMask=ramp\|iconMask=no\|texture=3"

	-- Cached items grouped by slot to prevent redundant full-table evaluations		-- Cached items grouped by slot to prevent redundant full-table evaluations
Line 94:		Line 103:
	if lang_code == "en" then		if lang_code == "en" then
	if is_street_brawl then		if is_street_brawl then
	item_template = "{{ItemBox\|itemName=" .. item_name_english .. "\|overrideLinkClick=" .. item_link .. "\|overrideTier=5}}"		item_template = "{{ItemBox\|itemName=" .. item_name_english .. "\|overrideLinkClick=" .. item_link .. "\|overrideTier=5" .. LOW_GRAPHICS .. "}}"
	else		else
	item_template = "{{ItemBox\|itemName=" .. item_name_english .. "\|overrideLinkClick=" .. item_link .. "}}"		item_template = "{{ItemBox\|itemName=" .. item_name_english .. "\|overrideLinkClick=" .. item_link .. LOW_GRAPHICS .. "}}"
	end		end
	else		else
	local link_local = item_link .. "/" .. lang_code		local link_local = item_link .. "/" .. lang_code
	if is_street_brawl then		if is_street_brawl then
	item_template = "{{ItemBox\|itemName=" .. item_name_english .. "\|overrideLinkClick=" .. link_local .. "\|item_price={{#invoke:Lang\|get_string\|Citadel_ItemDraft_Legendary}}}}"		item_template = "{{ItemBox\|itemName=" .. item_name_english .. "\|overrideLinkClick=" .. link_local .. "\|item_price={{#invoke:Lang\|get_string\|Citadel_ItemDraft_Legendary}}" .. LOW_GRAPHICS .. "}}"
	else		else
	item_template = "{{ItemBox\|itemName=" .. item_name_english .. "\|overrideLinkClick=" .. link_local .. "}}"		item_template = "{{ItemBox\|itemName=" .. item_name_english .. "\|overrideLinkClick=" .. link_local .. LOW_GRAPHICS .. "}}"
	end		end
	end		end

~2026-LaneLeechSecure746: Active Items table: use var(--color-subtle) for diminished notes (with help from vergir-bot LLM)

2026-07-23T20:40:21Z

Active Items table: use var(--color-subtle) for diminished notes (with help from vergir-bot LLM)

← Older revision		Revision as of 20:40, 23 July 2026
Line 237:		Line 237:
	local RANGE_PROPERTIES = { "AbilityCastRange", "Radius", "EndRadius" }		local RANGE_PROPERTIES = { "AbilityCastRange", "Radius", "EndRadius" }

	-- ~~Strips~~ the ~~icon~~ markup ~~from inline attributes, leaving plain wikilinks~~		-- Rewrites the description markup [[Module:Lang]] produces
	local function ~~restyle_inline_attributes~~(text)		local function restyle_description(text)
	text = text:gsub(INLINE_ATTRIBUTE_PATTERN, '[[%1\|%2]]')		text = text:gsub(INLINE_ATTRIBUTE_PATTERN, '[[%1\|%2]]')
	-- Attributes with an icon but no link keep their span; follow the site text color		-- Attributes with an icon but no link keep their span; follow the site text color
	~~return (~~text:gsub('color:#ffefd7;', 'color:var(--color-base);'))		text = text:gsub('color:#ffefd7;', 'color:var(--color-base);')
			-- Diminished notes ("Cannot be used while Stunned...")
			return (text:gsub('color:#C0C0C0', 'color:var(--color-subtle)'))
	end		end

Line 349:		Line 351:

	table.insert(rows, "\n\|}")		table.insert(rows, "\n\|}")
	return ~~restyle_inline_attributes~~(frame:preprocess(table.concat(rows, "\n")))		return restyle_description(frame:preprocess(table.concat(rows, "\n")))
	end		end

	return p		return p

~2026-LaneLeechSecure746: Active Items table: plain wikilinks for inline attributes, var(--color-base) for off-white styling, em dash for missing stats, add Duration and Cast Range columns (with help from vergir-bot LLM)

2026-07-23T20:32:21Z

Active Items table: plain wikilinks for inline attributes, var(--color-base) for off-white styling, em dash for missing stats, add Duration and Cast Range columns (with help from vergir-bot LLM)

@@ Line 1: / Line 1: @@
 local p = {}
 local items_data = mw.loadJsonData("Data:ItemData.json")
@@ Line 221: / Line 222: @@
 -- for [[Template:Active Items]]
 function p.generate_active_items_table(frame)
      local active_items = {}
@@ Line 231: / Line 282: @@
             item_data["Activation"] and
             item_data["Activation"] ~= "Passive" then
              table.insert(active_items, {
@@ Line 237: / Line 290: @@
                  cost = cost,
                  slot = item_data["Slot"] or "Weapon",
-                 has_active_desc = item_data["ActiveDescription"] ~= nil
+                 has_active_desc = item_data["ActiveDescription"] ~= nil,
              })
          end
@@ Line 252: / Line 309: @@
 ! {{Souls|{{#invoke:Dictionary|translate|Cost}}}}
 ! {{#invoke:Lang|get_string|Citadel_Mod_Tooltip_Active}}
-! {{#invoke:Lang|get_string|AbilityCooldown_label}}]=])
+! {{#invoke:Lang|get_string|AbilityCooldown_label}}
      for _, item in ipairs(active_items) do
@@ Line 273: / Line 332: @@
 | data-sort-value="%d" style="text-align:center;font-size:15px" | {{Souls|%d}}
 | {{#invoke:Utilities|process_variables|%s_active_desc|%s}}{{#invoke:Utilities|process_variables|%s_desc|%s}}{{#invoke:Utilities|process_variables|%s_active|%s}}
-| style="text-align:center;font-size:16px" | {{#invoke:ItemData|get_prop|%s|AbilityCooldown}}s]=],
+%s
              bg_color,
              item.name,
@@ Line 280: / Line 341: @@
              item.cost, item.cost,
              item.key, item.name, item.key, item.name, item.key, item.name,
-             item.name)
+             stat_cell(item.cooldown, item.name, "AbilityCooldown", "s"),
          table.insert(rows, row)
@@ Line 286: / Line 349: @@
      table.insert(rows, "\n|}")
-     return frame:preprocess(table.concat(rows, "\n"))
+     return restyle_inline_attributes(frame:preprocess(table.concat(rows, "\n")))
 end
 return p

LVL: Made active items table use the same item category background colors as the item navbox does

2026-07-05T16:25:26Z

Made active items table use the same item category background colors as the item navbox does

← Older revision		Revision as of 16:25, 5 July 2026
Line 255:		Line 255:

	for _, item in ipairs(active_items) do		for _, item in ipairs(active_items) do
	local bg_color, item_type		local bg_color = util_module.get_slot_color(item.slot)
	if item.slot == "Armor" then
	~~bg_color = "#86C921"~~		local item_type
	item_type = "Armor"		if item.slot == "Armor" then
	elseif item.slot == "Tech" then		item_type = "Armor"
	~~bg_color = "#DE9CFF"~~		elseif item.slot == "Tech" then
	item_type = "Tech"		item_type = "Tech"
	else		else
	~~bg_color = "#FCAC4D"~~		item_type = "Weapon"
	item_type = "Weapon"		end
	end

	local row = string.format([=[		local row = string.format([=[

Cronos: Refactored for performance optimization

2026-06-27T22:35:29Z

Refactored for performance optimization

Diff

Cronos at 22:33, 27 June 2026

2026-06-27T22:33:08Z

← Older revision		Revision as of 22:33, 27 June 2026
Line 81:		Line 81:
	end		end

	-- Wrap item ~~and its bullet separator~~ in a searchable span		-- Wrap item in an open searchable span (closing tags and bullets added post-sort)
	item_template = '<span class="item-nav-search-wrapper"><span class="item-nav-search-item" data-item-name="' .. search_data .. '">' .. item_template .. '~~</span><span class="item-nav-search-sep"> • </span>~~</span>'		item_template = '<span class="item-nav-search-wrapper"><span class="item-nav-search-item" data-item-name="' .. search_data .. '">' .. item_template .. '</span>'
	elseif template == "ItemBox" then		elseif template == "ItemBox" then
	if lang_code == "en" then		if lang_code == "en" then
Line 112:		Line 112:
	-- Order list alphabetically		-- Order list alphabetically
	table.sort(items) -- O(nlogn)		table.sort(items) -- O(nlogn)

			-- Append closing tags and bullets (omitting the bullet for the last item)
			if template == "ItemIcon" then
			for i = 1, #items do
			if i == #items then
			items[i] = items[i] .. '</span>'
			else
			items[i] = items[i] .. '<span class="item-nav-search-sep"> • </span></span>'
			end
			end
			end

	-- Add each item to output		-- Add each item to output
	~~-- Each item is already wrapped in the template, so no need for additional wrapping~~
	local ret = table.concat(items, sep)		local ret = table.concat(items, sep)