Module:ItemData/nav: Difference between revisionsGive feedback
Jump to navigation
Jump to search
No edit summary |
Refactored for performance optimization |
||
| Line 5: | Line 5: | ||
local util_module = require('Module:Utilities') | local util_module = require('Module:Utilities') | ||
-- | -- Exceptions if the link is different from the item name | ||
local linkOverrides = { | local linkOverrides = { | ||
["Bullet Lifesteal"] = "Bullet Lifesteal (item)", | ["Bullet Lifesteal"] = "Bullet Lifesteal (item)", | ||
| Line 11: | Line 11: | ||
} | } | ||
-- | -- Cached items grouped by slot to prevent redundant full-table evaluations | ||
--With debug_mode | local cached_slots = nil | ||
local function get_items_by_slot(slot) | |||
if not cached_slots then | |||
cached_slots = { table = {}, Weapon = {}, Armor = {}, Tech = {} } | |||
for item_key, item_data in pairs(items_data) do | |||
local this_slot = item_data["Slot"] | |||
if this_slot and cached_slots[this_slot] then | |||
table.insert(cached_slots[this_slot], { key = item_key, data = item_data }) | |||
end | |||
end | |||
end | |||
return cached_slots[slot] or {} | |||
end | |||
-- With debug_mode on, it outputs unprocessed wikitext | |||
local function process_debug_mode(wikitext, debug_mode) | local function process_debug_mode(wikitext, debug_mode) | ||
if debug_mode == 'true' then | |||
return wikitext | |||
elseif debug_mode == 'false' or debug_mode == nil then | |||
return mw.getCurrentFrame():preprocess(wikitext) | |||
else | |||
return "debug_mode must be 'true' or 'false'" | |||
end | |||
end | end | ||
--Writes list of items of a certain slot within the min and max soul bounds | -- Writes list of items of a certain slot within the min and max soul bounds | ||
local function write_wrapped_item_list(slot, min_souls, max_souls, template, sep, filter_mode) | local function write_wrapped_item_list(slot, min_souls, max_souls, template, sep, filter_mode) | ||
if slot ~= 'Weapon' and slot ~= 'Armor' and slot ~= 'Tech' then | if slot ~= 'Weapon' and slot ~= 'Armor' and slot ~= 'Tech' then | ||
| Line 37: | Line 47: | ||
if min_souls == nil or max_souls == nil then return 'Min/Max souls must be numerical' end | if min_souls == nil or max_souls == nil then return 'Min/Max souls must be numerical' end | ||
filter_mode = filter_mode or "all" | filter_mode = filter_mode or "all" | ||
-- | -- Lifted out of the loop: Language code doesn't change per item | ||
local lang_code = lang_module.get_lang_code() | |||
local items = {} | local items = {} | ||
for | local slot_items = get_items_by_slot(slot) -- Drastically reduces search pool size | ||
for _, item_entry in ipairs(slot_items) do | |||
local item_key = item_entry.key | |||
local item_data = item_entry.data | |||
local this_cost = tonumber(item_data["Cost"]) | local this_cost = tonumber(item_data["Cost"]) | ||
local is_street_brawl = item_data["StreetBrawl"] == true | local is_street_brawl = item_data["StreetBrawl"] == true | ||
local should_include = true | local should_include = true | ||
-- Filter logic for Street Brawl items | |||
if filter_mode == "street_brawl_only" and not is_street_brawl then | if filter_mode == "street_brawl_only" and not is_street_brawl then | ||
should_include = false | should_include = false | ||
| Line 57: | Line 70: | ||
end | end | ||
if should_include and item_data["Name"] ~= nil and item_data["IsDisabled"] == false and this_cost | if should_include and item_data["Name"] ~= nil and item_data["IsDisabled"] == false and this_cost ~= nil then | ||
if | if this_cost >= min_souls and this_cost < max_souls then | ||
local item_name_english = lang_module.get_string(item_key, "en") | local item_name_english = lang_module.get_string(item_key, "en") | ||
local item_link = linkOverrides[item_name_english] or item_name_english | local item_link = linkOverrides[item_name_english] or item_name_english | ||
local item_name_local = lang_module.get_string(item_key, lang_code) | |||
local item_name_local = lang_module.get_string(item_key, lang_code) | |||
local item_template | local item_template | ||
if template == "ItemIcon" then | if template == "ItemIcon" then | ||
if lang_code == "en" then | if lang_code == "en" then | ||
item_template = "{{ItemIcon|" .. item_name_english .. "|size=26px}}" | item_template = "{{ItemIcon|" .. item_name_english .. "|size=26px}}" | ||
else | else | ||
item_template = "{{ItemIcon|" .. item_name_english .. "|lang=" .. lang_code .. "|l1=" .. item_name_local .. "|size=26px}}" | item_template = "{{ItemIcon|" .. item_name_english .. "|lang=" .. lang_code .. "|l1=" .. item_name_local .. "|size=26px}}" | ||
end | end | ||
local search_data = item_name_english | local search_data = item_name_english | ||
if lang_code ~= "en" and item_name_local then | if lang_code ~= "en" and item_name_local then | ||
| Line 81: | Line 89: | ||
end | end | ||
item_template = '<span class="item-nav-search-wrapper"><span class="item-nav-search-item" data-item-name="' .. search_data .. '">' .. item_template .. '</span>' | item_template = '<span class="item-nav-search-wrapper"><span class="item-nav-search-item" data-item-name="' .. search_data .. '">' .. item_template .. '</span>' | ||
elseif template == "ItemBox" then | elseif template == "ItemBox" then | ||
if lang_code == "en" then | if lang_code == "en" then | ||
if is_street_brawl then | |||
item_template = "{{ItemBox|itemName=" .. item_name_english .. "|overrideLinkClick=" .. item_link .. "|overrideTier=5}}" | |||
if is_street_brawl | |||
else | else | ||
item_template = "{{ItemBox|itemName=" .. item_name_english .. "|overrideLinkClick=" .. item_link .. "}}" | item_template = "{{ItemBox|itemName=" .. item_name_english .. "|overrideLinkClick=" .. item_link .. "}}" | ||
end | end | ||
else | else | ||
local link_local = item_link .. "/" .. lang_code | |||
local link_local = item_link .. "/" .. lang_code | if is_street_brawl then | ||
if is_street_brawl | item_template = "{{ItemBox|itemName=" .. item_name_english .. "|overrideLinkClick=" .. link_local .. "|item_price={{#invoke:Lang|get_string|Citadel_ItemDraft_Legendary}}}}" | ||
item_template = "{{ItemBox|itemName=" .. item_name_english .. "|overrideLinkClick=" .. link_local .. | |||
else | else | ||
item_template = "{{ItemBox|itemName=" .. item_name_english .. "|overrideLinkClick=" .. link_local .. "}}" | |||
end | end | ||
end | end | ||
| Line 111: | Line 114: | ||
-- Order list alphabetically | -- Order list alphabetically | ||
table.sort(items | table.sort(items) | ||
-- Append closing tags and bullets | -- Append closing tags and bullets | ||
if template == "ItemIcon" then | if template == "ItemIcon" then | ||
for i = 1, | local total_items = #items | ||
if i == | for i = 1, total_items do | ||
if i == total_items then | |||
items[i] = items[i] .. '</span>' | items[i] = items[i] .. '</span>' | ||
else | else | ||
| Line 124: | Line 128: | ||
end | end | ||
return table.concat(items, sep) | |||
end | end | ||
-- for [[Template:Item Navbox]] | -- for [[Template:Item Navbox]] | ||
function p.get_item_nav_bulletpoints(slot, min_souls, max_souls, debug_mode, filter_mode) | function p.get_item_nav_bulletpoints(slot, min_souls, max_souls, debug_mode, filter_mode) | ||
if type(slot) == "table" and slot.args then | if type(slot) == "table" and slot.args then | ||
local frame = slot | local frame = slot | ||
| Line 142: | Line 141: | ||
filter_mode = frame.args["filter"] | filter_mode = frame.args["filter"] | ||
end | end | ||
local item_list = write_wrapped_item_list(slot, min_souls, max_souls, "ItemIcon", '', filter_mode) | |||
local item_list = write_wrapped_item_list(slot, min_souls, max_souls, "ItemIcon", | |||
return process_debug_mode(item_list, debug_mode) | return process_debug_mode(item_list, debug_mode) | ||
end | end | ||
-- for [[Template:Infobox ShopItems]] | -- for [[Template:Infobox ShopItems]] | ||
function p.get_item_nav_cards(slot, min_souls, max_souls, debug_mode, filter_mode) | function p.get_item_nav_cards(slot, min_souls, max_souls, debug_mode, filter_mode) | ||
if type(slot) == "table" and slot.args then | if type(slot) == "table" and slot.args then | ||
local frame = slot | local frame = slot | ||
| Line 162: | Line 156: | ||
filter_mode = frame.args["filter"] | filter_mode = frame.args["filter"] | ||
end | end | ||
local item_list = write_wrapped_item_list(slot, min_souls, max_souls, "ItemBox", ' ', filter_mode) | |||
local item_list = write_wrapped_item_list(slot, min_souls, max_souls, "ItemBox", | |||
return process_debug_mode(item_list, debug_mode) | return process_debug_mode(item_list, debug_mode) | ||
end | end | ||
-- for [[Template:Item Navbox]] subgroup rows | -- for [[Template:Item Navbox]] subgroup rows | ||
function p.write_item_slot_subgroup(frame) | function p.write_item_slot_subgroup(frame) | ||
local slot = frame.args[1] | |||
local type_func = frame.args[2] | |||
local debug_mode = frame.args['debug_mode'] | |||
local street_brawl_label = frame.args['street_brawl_label'] or '{{Legendary|{{#invoke:Lang|get_string|Citadel_ItemDraft_Legendary}}}}' | |||
if slot == nil then return "'slot' parameter is required" end | |||
local template_args = { | |||
["groupstyle"] = "background-color:" .. util_module.get_slot_color(slot) .. ";width:10%;min-width:70px;border-radius: 8px 0 0 8px", | |||
["grouppadding"] = "5px", | |||
["listpadding"] = "0 0.25rem", | |||
} | |||
local soul_style = "font-size: 12px; text-shadow: 1px 1px rgba(0, 0, 0, 0.3);" | |||
local prices = generic_module.get_item_price_per_tier() | |||
local group_index = 1 | |||
for i, souls in ipairs(prices) do | |||
local min_souls = souls | |||
if min_souls ~= 0 then | |||
local max_souls = prices[i+1] or (min_souls * 10) | |||
local list | |||
if type_func == 'get_item_nav_cards' then | |||
list = p.get_item_nav_cards(slot, min_souls, max_souls, debug_mode, "exclude_street_brawl") | |||
elseif type_func == 'get_item_nav_bulletpoints' then | |||
list = p.get_item_nav_bulletpoints(slot, min_souls, max_souls, debug_mode, "exclude_street_brawl") | |||
else | |||
return "'type' should be get_item_nav_cards or get_item_nav_bulletpoints" | |||
end | |||
if list and list ~= "" then | |||
template_args["group" .. group_index] = frame:expandTemplate{title="Souls", args={[1] = min_souls, ["Shadow"] = soul_style}} | |||
template_args["list" .. group_index] = list | |||
group_index = group_index + 1 | |||
end | |||
end | |||
end | |||
local sb_list | |||
if type_func == 'get_item_nav_cards' then | |||
sb_list = p.get_item_nav_cards(slot, 0, 999999, debug_mode, "street_brawl_only") | |||
elseif type_func == 'get_item_nav_bulletpoints' then | |||
sb_list = p.get_item_nav_bulletpoints(slot, 0, 999999, debug_mode, "street_brawl_only") | |||
end | |||
if sb_list and sb_list ~= "" then | |||
local sb_style = "color:#98ffde; font-family:'Retail Demo', sans-serif; text-wrap: nowrap; text-shadow: 0px 0px 2px #2c312e, 1.3px 1.3px rgba(0, 0, 0, 0.2);padding:5px;" | |||
local sb_link_text = "[[Street Brawl{{if_lang}}|<span style=\"" .. sb_style .. "\"><b>" .. street_brawl_label .. "</b></span>]]" | |||
template_args["group" .. group_index] = frame:preprocess(sb_link_text) | |||
template_args["list" .. group_index] = sb_list | |||
end | |||
return frame:expandTemplate{title="Navbox subgroup", args=template_args} | |||
end | end | ||
| Line 249: | Line 224: | ||
local active_items = {} | local active_items = {} | ||
for item_key, item_data in pairs(items_data) do | for item_key, item_data in pairs(items_data) do | ||
local cost = tonumber(item_data["Cost"]) | local cost = tonumber(item_data["Cost"]) | ||
if item_data["Name"] and | if item_data["Name"] and | ||
item_data["IsDisabled"] == false and | item_data["IsDisabled"] == false and | ||
cost ~= nil and cost > 0 and | cost ~= nil and cost > 0 and | ||
item_data["Activation"] and | item_data["Activation"] and | ||
item_data["Activation"] ~= "Passive" then | item_data["Activation"] ~= "Passive" then | ||
| Line 270: | Line 242: | ||
end | end | ||
table.sort(active_items, function(a, b) return a.name < b.name end) | table.sort(active_items, function(a, b) return a.name < b.name end) | ||
-- | -- Optimized string compilation using a structural buffer table | ||
local | local rows = {} | ||
table.insert(rows, [=[{| class="wikitable mw-collapsible sortable" style="width:100%" | |||
|+{{#invoke:Dictionary|translate|Active Items}} | |+{{#invoke:Dictionary|translate|Active Items}} | ||
! colspan="2" | {{#invoke:Lang|get_string|Citadel_HeroBuilds_CategoryNameLabel}} | ! colspan="2" | {{#invoke:Lang|get_string|Citadel_HeroBuilds_CategoryNameLabel}} | ||
| Line 280: | Line 252: | ||
! {{Souls|{{#invoke:Dictionary|translate|Cost}}}} | ! {{Souls|{{#invoke:Dictionary|translate|Cost}}}} | ||
! {{#invoke:Lang|get_string|Citadel_Mod_Tooltip_Active}} | ! {{#invoke:Lang|get_string|Citadel_Mod_Tooltip_Active}} | ||
! {{#invoke:Lang|get_string|AbilityCooldown_label}} | ! {{#invoke:Lang|get_string|AbilityCooldown_label}}]=]) | ||
]=] | |||
for _, item in ipairs(active_items) do | for _, item in ipairs(active_items) do | ||
local bg_color, item_type | local bg_color, item_type | ||
if item.slot == "Armor" then | if item.slot == "Armor" then | ||
| Line 298: | Line 267: | ||
end | end | ||
local row = string.format([=[ | |||
|- | |- | ||
! style="background-color:%s" | [[File:%s.png|64x64px]] | ! style="background-color:%s" | [[File:%s.png|64x64px]] | ||
| Line 307: | Line 274: | ||
| data-sort-value="%d" style="text-align:center;font-size:15px" | {{Souls|%d}} | | data-sort-value="%d" style="text-align:center;font-size:15px" | {{Souls|%d}} | ||
| {{#invoke:Utilities|process_variables|%s_active_desc|%s}}{{#invoke:Utilities|process_variables|%s_desc|%s}}{{#invoke:Utilities|process_variables|%s_active|%s}} | | {{#invoke:Utilities|process_variables|%s_active_desc|%s}}{{#invoke:Utilities|process_variables|%s_desc|%s}}{{#invoke:Utilities|process_variables|%s_active|%s}} | ||
| style="text-align:center;font-size:16px" | {{#invoke:ItemData|get_prop|%s|AbilityCooldown}}s | | style="text-align:center;font-size:16px" | {{#invoke:ItemData|get_prop|%s|AbilityCooldown}}s]=], | ||
]=], | |||
bg_color, | bg_color, | ||
item.name, | item.name, | ||
| Line 316: | Line 282: | ||
item.key, item.name, item.key, item.name, item.key, item.name, | item.key, item.name, item.key, item.name, item.key, item.name, | ||
item.name) | item.name) | ||
table.insert(rows, row) | |||
end | end | ||
table.insert(rows, "\n|}") | |||
return frame:preprocess(table.concat(rows, "\n")) | |||
return frame:preprocess( | |||
end | end | ||
return p | return p | ||