Editing Module:NpcDataGive feedback

local p = {}

-- Load data and utility modules
local npcs_data = mw.loadJsonData("Data:NpcData.json")
local util_module = require('Module:Utilities')
local lang_module = require('Module:Lang')

-- returns the entire data table for a specific NPC, used by other Lua modules
function p.get_npc_data(name)
	if not name or name == '' then
		return nil
	end
	return npcs_data[name]
end

-- Retrieves a specific stat value for a given NPC.
-- Retrieves a specific stat value for a given NPC. Handles both simple and nested calls.
--{{#invoke:NpcData|get_npc_var|NPC_KEY|STAT_KEY_1|STAT_KEY_2|...|SIG_FIGS}}--
p.get_npc_var = function(frame)
	-- Use pcall to handle both template and module calls gracefully
	local parent_args = frame:getParent() and frame:getParent().args or {}
	local direct_args = frame.args
	local args = {}
	-- Merge args, giving direct #invoke args priority
	for k, v in pairs(parent_args) do args[k] = v end
	for k, v in pairs(direct_args) do args[k] = v end

	local npc_name = args[1] and mw.text.trim(args[1]) or nil
	if not npc_name or npc_name == '' then
		return '<span class="error">Error: NPC name not provided.</span>'
	end

	local npc = npcs_data[npc_name]
	if not npc then
		return '<span class="error">Error: NPC "' .. npc_name .. '" not found.</span>'
	end

	local current_value = npc
	local last_key_index = 1

	-- Traverse through the arguments to find the nested value
	for i = 2, #args do
		local key = args[i] and mw.text.trim(args[i]) or nil
		if not key or key == '' then break end

		-- Stop traversing if the next key looks like a number for rounding
		if tonumber(key) then
			break
		end

		if type(current_value) ~= "table" then
			return '<span class="error">Error: Invalid path. Tried to index a non-table value.</span>'
		end
		
		current_value = current_value[key]
		if current_value == nil then
			return '<span class="error">Error: Key "' .. key .. '" not found.</span>'
		end
		last_key_index = i
	end

	-- Determine if a rounding value was provided
	local sig_figs_arg = args[last_key_index + 1]
	local sig_figs = sig_figs_arg and tonumber(mw.text.trim(sig_figs_arg)) or nil
	
	if sig_figs then
		current_value = util_module.round_to_sig_fig(current_value, sig_figs)
		if current_value == nil then
			return '<span class="error">Error: Rounding failed for value.</span>'
		end
	end

	return current_value
end

-- Retrieves an element from a list (array) within an NPC's data.
--{{#invoke:NpcData|get_list_elem|NPC_KEY|LIST_KEY|INDEX}}--
p.get_list_elem = function(frame)
	local npc_name = frame.args[1] and mw.text.trim(frame.args[1]) or nil
	local var = frame.args[2] and mw.text.trim(frame.args[2]) or nil
	local number_str = frame.args[3] and mw.text.trim(frame.args[3]) or nil
	
	if not npc_name or npc_name == '' then return '<span class="error">Error: NPC name not provided.</span>' end
	if not var or var == '' then return '<span class="error">Error: List variable name not provided.</span>' end
	if not number_str or number_str == '' then return '<span class="error">Error: Index not provided.</span>' end
	
	local number_int = tonumber(number_str)
	if not number_int then return '<span class="error">Error: Invalid index provided. Must be a number.</span>' end

	local npc = npcs_data[npc_name]
	if not npc then return '<span class="error">Error: NPC "' .. npc_name .. '" not found.</span>' end
	
	local list = npc[var]
	if list == nil or type(list) ~= "table" then return "" end
	
	local element = list[number_int]
	if element == nil then return "" end
	
	return element
end

-- Retrieves a nested value using dot notation (e.g., "Shield.BaseAbsorptionPerSecond")
--{{#invoke:NpcData|get_nested_var|NPC_KEY|PATH|SIG_FIGS}}--
p.get_nested_var = function(frame)
	local args = frame.args
	local npc_name = args[1] and mw.text.trim(args[1]) or nil
	local path = args[2] and mw.text.trim(args[2]) or nil
	local sig_figs = args[3] and mw.text.trim(args[3]) or nil

	if not npc_name or npc_name == '' then
		return '<span class="error">Error: NPC name not provided.</span>'
	end
	if not path or path == '' then
		return '<span class="error">Error: Path not provided.</span>'
	end

	local npc = npcs_data[npc_name]
	if not npc then
		return '<span class="error">Error: NPC "' .. npc_name .. '" not found.</span>'
	end

	-- Traverse nested structure
	local value = npc
	for key in string.gmatch(path, '([^.]+)') do
	    if type(value) ~= "table" then
	        return '<span class="error">Error: Path "' .. path .. '" is invalid.</span>'
	    end
	    -- try first with the raw key, then with a number conversion
	    local next = value[key] or value[tonumber(key)] or value[tostring(key)]
	    if next == nil then
	        return '<span class="error">Error: Key "' .. key .. '" not found in path.</span>'
	    end
	    value = next
	end

	-- Apply rounding if needed
	if sig_figs and tonumber(sig_figs) then
		value = util_module.round_to_sig_fig(value, sig_figs)
		if value == nil then
			return '<span class="error">Error: Rounding failed for value.</span>'
		end
	end

	return value
end

return p