Editing Module:BuildupGive feedback

local p = {}

local heroes_data = mw.loadJsonData("Data:HeroData.json")
local items_data = mw.loadJsonData("Data:ItemData.json")

-- Helper to find Item Buildup value by name
-- Handles both flat numbers and lookup in the ItemData file
local function get_item_bb(target_name)
	if target_name == nil then return nil end
	
	-- Clean input
	local clean_name = mw.text.trim(target_name)
	
	-- If user input a number directly
	if tonumber(clean_name) then return tonumber(clean_name) end

	-- Iterate Item Data
	for key, item in pairs(items_data) do
		if item["Name"] == clean_name then
			
			-- Valve data structure (nested)
			if item["m_mapAbilityProperties"] and item["m_mapAbilityProperties"]["BuildUpPerShot"] then
				return tonumber(item["m_mapAbilityProperties"]["BuildUpPerShot"]["m_strValue"])
			end
			
			-- Flat data structure (fallback)
			if item["BuildUpPerShot"] then
				return tonumber(item["BuildUpPerShot"])
			end
		end
	end
	return nil
end

-- Helper to find Hero Data by name or key
local function get_hero_data(hero_name)
	if hero_name == nil then return nil end
	
	local clean_name = mw.text.trim(hero_name)
	
	-- Try direct Key lookup
	if heroes_data[clean_name] then return heroes_data[clean_name] end
	
	-- Try adding "hero_" prefix
	local key_lower = "hero_" .. string.lower(clean_name)
	if heroes_data[key_lower] then return heroes_data[key_lower] end
	
	-- Search by Name field
	for k, v in pairs(heroes_data) do
		if v["Name"] == clean_name then return v end
	end
	return nil
end

-- Core calculation logic
local function calculate_bps(hero, bb)
	if not hero or not hero.Weapon then return 0 end

	local rps = tonumber(hero.Weapon.RoundsPerSecond or 0)
	local spin_rps = tonumber(hero.Weapon.RoundsPerSecondAtMaxSpin or 0)
	
	-- Handle Spin-up logic (McGinnis/Bebop)
	-- If they have a max spin speed, use that instead of base RPS
	if spin_rps > 0 then rps = spin_rps end

	if rps == 0 then return 0 end

	-- Formula: 100 / (BB * (RPS + 1))
	return 100 / (bb * (rps + 1))
end

--{{#invoke:Buildup|get_bps|HERO_NAME|ITEM_NAME}}
--Returns a single float value (rounded to 1 decimal)
p.get_bps = function(frame)
	local hero_name = frame.args[1] or frame.args['hero']
	local item_name = frame.args[2] or frame.args['item']

	local hero = get_hero_data(hero_name)
	if not hero then return "Hero Not Found" end

	local bb = get_item_bb(item_name)
	if not bb then return "Item Not Found" end

	local result = calculate_bps(hero, bb)
	return string.format("%.1f", result)
end

--{{#invoke:Buildup|write_buildup_table|ITEM_NAME}}
--Generates a sortable wikitable for all heroes
p.write_buildup_table = function(frame)
	local item_name = frame.args[1]
	
	local bb = get_item_bb(item_name)
	if not bb then return "Error: Item '" .. (item_name or "nil") .. "' not found." end

	local hero_list = {}
	
	-- Collect valid heroes
	for key, hero in pairs(heroes_data) do
		local is_dev = hero["InDevelopment"] == true
		local is_disabled = hero["IsDisabled"] == true
		
		if not is_dev and not is_disabled and hero["Weapon"] then
			local val = calculate_bps(hero, bb)
			
			if val > 0 then
				-- Calculate shots needed (Rounding UP is crucial for 19.99% edge cases)
				local shots = math.ceil(100 / val)
				
				table.insert(hero_list, {
					name = hero["Name"],
					bps = val,
					shots = shots
				})
			end
		end
	end

	-- Sort Alphabetically
	table.sort(hero_list, function(a, b) return a.name < b.name end)

	-- Build Table
	local html = mw.html.create('table')
	html:addClass('wikitable sortable mw-collapsible')
	
	if item_name then
		html:tag('caption'):wikitext('Buildup Per Shot: ' .. item_name)
	end

	-- Headers
	local headerRow = html:tag('tr')
	headerRow:tag('th'):wikitext('Hero')
	headerRow:tag('th'):wikitext('% per shot')
	headerRow:tag('th'):wikitext('Shots to Proc')

	-- Rows
	for _, h in ipairs(hero_list) do
		local row = html:tag('tr')
		
		-- Expand HeroIcon template
		local icon_template = frame:expandTemplate{ title = 'HeroIcon', args = { h.name } }
		
		row:tag('td'):wikitext(icon_template)
		row:tag('td'):wikitext(string.format("%.1f", h.bps))
		row:tag('td'):wikitext(tostring(h.shots))
	end

	return tostring(html)
end

-- Main entry point for the template
-- Decides whether to return a single value or a full table based on arguments
p.main = function(frame)
	local args = frame:getParent().args
	-- Handle direct #invoke calls vs Template calls
	if not args[1] and not args['item'] then args = frame.args end

	local arg1 = args[1] or args['hero']
	local arg2 = args[2] or args['item']

	-- If both Hero and Item are present -> Return Single Number
	if arg1 and arg2 then
		-- Manually setting args for the helper function to read
		frame.args = {arg1, arg2}
		return p.get_bps(frame)
		
	-- If only one arg (Item) is present -> Return Table
	elseif arg1 then
		frame.args = {arg1}
		return p.write_buildup_table(frame)
		
	else
		return "Error: Provide [Item Name] for a table, or [Hero Name] [Item Name] for a value."
	end
end

return p