Module:HeroData: Difference between revisionsGive feedback
Jump to navigation
Jump to search
Now bucket 3 fixed |
Consolidate stat/scaling lookups into shared helpers, add resolve_key and has_tags, drop unused dependencies and dead code (with help from vergir-bot LLM) |
||
| Line 1: | Line 1: | ||
local p = {}; | local p = {}; | ||
local heroes_data = mw.loadJsonData("Data:HeroData.json") | local heroes_data = mw.loadJsonData("Data:HeroData.json") | ||
local util_module = require('Module:Utilities') | local util_module = require('Module:Utilities') | ||
local lang_module = require('Module:Lang') | local lang_module = require('Module:Lang') | ||
local | |||
local | -------------------------------------------------------------------------------- | ||
-- Internal helpers | |||
-------------------------------------------------------------------------------- | |||
-- Localized string for a key, falling back to a readable version of `fallback` | |||
-- plus a "missing translation" tooltip. | |||
local function localize(key, fallback) | |||
local result = lang_module.get_string(key) | |||
if (result == "") or (result == nil) then | |||
result = util_module.add_space_before_cap(fallback) .. mw.getCurrentFrame():expandTemplate{title="MissingValveTranslationTooltip"} | |||
end | |||
return result | |||
end | |||
-- Raw scaling value of a stat under LevelScaling / SpiritScaling, or nil when | |||
-- the hero has no scaling of that type for that stat. | |||
local function raw_scaling(hero_data, scaling_type, stat) | |||
local scaling = hero_data and hero_data[scaling_type .. "Scaling"] | |||
if (scaling == nil or stat == nil) then return nil end | |||
return scaling[stat] | |||
end | |||
-- Mapping from hero name to internal tag name | |||
local TAG_NAME_MAP = { | |||
["Abrams"] = "Abrams", | |||
["Bebop"] = "Bebop", | |||
["Billy"] = "Punkgoat", | |||
["Calico"] = "Nano", | |||
["The Doorman"] = "Doorman", | |||
["Drifter"] = "Drifter", | |||
["Dynamo"] = "Dynamo", | |||
["Apollo"] = "Fencer", | |||
["Graves"] = "Necro", | |||
["Grey Talon"] = "Orion", | |||
["Haze"] = "Haze", | |||
["Holliday"] = "Astro", | |||
["Infernus"] = "Inferno", | |||
["Ivy"] = "Tengu", | |||
["Kelvin"] = "Kelvin", | |||
["Lady Geist"] = "Geist", | |||
["Lash"] = "Lash", | |||
["McGinnis"] = "Engineer", | |||
["Mina"] = "VampireBat", | |||
["Mirage"] = "Mirage", | |||
["Mo & Krill"] = "Digger", | |||
["Paige"] = "Bookworm", | |||
["Paradox"] = "Chrono", | |||
["Celeste"] = "Unicorn", | |||
["Pocket"] = "Synth", | |||
["Rem"] = "Familiar", | |||
["Seven"] = "Gigawatt", | |||
["Shiv"] = "Shiv", | |||
["Silver"] = "Werewolf", | |||
["Silver (Transformed)"] = "Werewolf", | |||
["Sinclair"] = "Magician", | |||
["Venator"] = "Priest", | |||
["Victor"] = "Frank", | |||
["Vindicta"] = "Vindicta", | |||
["Viscous"] = "Viscous", | |||
["Vyper"] = "Viper", | |||
["Warden"] = "Warden", | |||
["Wraith"] = "Wraith", | |||
["Yamato"] = "Yamato", | |||
} | |||
-------------------------------------------------------------------------------- | |||
-- Data access, for use by other modules | |||
-------------------------------------------------------------------------------- | |||
-- returns the table of a specific item, used by external modules | -- returns the table of a specific item, used by external modules | ||
| Line 18: | Line 83: | ||
end | end | ||
-- | -- Hero table for a hero_* key or an exact English name, or nil. | ||
-- | local function hero_by_key_or_name(input) | ||
-- | local hero = heroes_data[input] | ||
-- | if (hero == nil) then hero = p.get_json_item(input) end | ||
return hero | |||
local | end | ||
for _, | |||
if ( | -- Value of a stat, checking the hero's top level, then Weapon, then AltFire. | ||
table.insert( | -- Returns nil when the hero has no such stat. | ||
function p.get_stat(hero_data, stat) | |||
if (hero_data == nil or stat == nil) then return nil end | |||
local value = hero_data[stat] | |||
if (value == nil and hero_data.Weapon) then | |||
value = hero_data.Weapon[stat] | |||
end | |||
if (value == nil and hero_data.Weapon and hero_data.Weapon.AltFire) then | |||
value = hero_data.Weapon.AltFire[stat] | |||
end | |||
return value | |||
end | |||
-- Ordered list of a hero's scalings for a stat, Level first then Spirit: | |||
-- { { type = "Level", value = 1.5 }, { type = "Spirit", value = 0.04 } } | |||
-- Absent scalings are omitted, so an empty list means "no scaling". Zero | |||
-- scalings are omitted too unless include_zero is set, which only the | |||
-- deprecated get_hero_scaling_data below needs. | |||
function p.get_scalings(hero_data, stat, include_zero) | |||
local scalings = {} | |||
for _, scaling_type in ipairs({"Level", "Spirit"}) do | |||
local value = raw_scaling(hero_data, scaling_type, stat) | |||
if (value ~= nil and (include_zero or value ~= 0)) then | |||
table.insert(scalings, { type = scaling_type, value = value }) | |||
end | end | ||
end | end | ||
return | return scalings | ||
end | end | ||
-- DEPRECATED, kept for [[Module:HeroComparisonTable]]. Use p.get_scalings. | |||
-- Keyed by scaling value, so it silently drops an entry when Level and Spirit | |||
-- scale by the same amount, and it keeps zero scalings. | |||
function p.get_hero_scaling_data(hero_data, hero_stat_key) | |||
local scaling_data_returned = {} | |||
-- Walked backwards so Level is written last and wins a value collision, | |||
-- matching the original Spirit-then-Level assignment order. | |||
local scalings = p.get_scalings(hero_data, hero_stat_key, true) | |||
for i = #scalings, 1, -1 do | |||
scaling_data_returned[scalings[i].value] = scalings[i].type | |||
end | |||
return scaling_data_returned | |||
end | |||
-- Whether a hero has a stat at all: a non-zero base value, or any scaling. | |||
function p.has_stat(hero_data, stat) | |||
local base = p.get_stat(hero_data, stat) | |||
if (base ~= nil and base ~= 0) then return true end | |||
return #p.get_scalings(hero_data, stat) > 0 | |||
end | |||
-- Resolves a hero_* key or an English hero name to a hero_* key. | |||
-- Returns nil when the input matches no hero. Name matching is case-insensitive. | |||
function p.find_hero_key(input) | |||
if (input == nil or input == '') then return nil end | |||
if (heroes_data[input] ~= nil) then return input end | |||
local wanted = mw.ustring.lower(input) | |||
for hero_key, hero_data in pairs(heroes_data) do | |||
if (hero_data["Name"] and mw.ustring.lower(hero_data["Name"]) == wanted) then | |||
return hero_key | |||
end | |||
end | |||
return nil | |||
end | |||
-- A hero's Nth roster tag (1-3) by English name, or '' when there is no such tag. | |||
function p.hero_tag(hero_en, index) | |||
local tagname = hero_en and TAG_NAME_MAP[hero_en] | |||
if (tagname == nil) then return '' end | |||
if (index ~= 1 and index ~= 2 and index ~= 3) then return '' end | |||
return lang_module.get_string(string.format("Citadel_%s_HeroTag_%d", tagname, index)) or '' | |||
end | |||
-------------------------------------------------------------------------------- | |||
-- Wikitext entry points | |||
-------------------------------------------------------------------------------- | |||
-- returns the key of the specified hero's english name | -- returns the key of the specified hero's english name | ||
function p.get_hero_key(frame) | function p.get_hero_key(frame) | ||
local hero_name_input = frame.args[1] | |||
if not hero_name_input then | |||
return "Error: Hero name not specified." | |||
end | |||
return p.find_hero_key(hero_name_input) or "Hero not found." | |||
end | |||
--{{#invoke:HeroData|resolve_key|HERO_KEY_OR_NAME}}-- | |||
-- The matching hero_* key, or '' when the input matches no hero. | |||
function p.resolve_key(frame) | |||
return p.find_hero_key(frame.args[1]) or '' | |||
end | end | ||
| Line 61: | Line 189: | ||
local sig_figs_or_localize = frame.args[3] | local sig_figs_or_localize = frame.args[3] | ||
local hero = | local hero = hero_by_key_or_name(hero_name) | ||
if(hero == nil) then return "Hero Not Found" end | if(hero == nil) then return "Hero Not Found" end | ||
local var_value = p.get_stat(hero, hero_stat_key) | |||
local var_value = | |||
if(var_value == nil) then return 0 end | if(var_value == nil) then return 0 end | ||
| Line 96: | Line 215: | ||
local sig_figs_or_localize = frame.args[3] | local sig_figs_or_localize = frame.args[3] | ||
local hero = | local hero = hero_by_key_or_name(hero_name) | ||
if(hero == nil) then return "Hero Not Found" end | if(hero == nil) then return "Hero Not Found" end | ||
| Line 124: | Line 242: | ||
local hero_name = frame.args[1] | local hero_name = frame.args[1] | ||
local var = frame.args[2] | local var = frame.args[2] | ||
local | local number_int = tonumber(frame.args[3]) | ||
local localize_arg = frame.args[4] | |||
local | |||
local hero = | local hero = hero_by_key_or_name(hero_name) | ||
if(hero == nil) then return "Hero Not Found" end | if(hero == nil) then return "Hero Not Found" end | ||
local list = p.get_stat(hero, var) | |||
local list = | |||
if (list == nil) then return "" end | if (list == nil) then return "" end | ||
local element = list[number_int] | local element = list[number_int] | ||
if (element == nil) then return "" end | if (element == nil) then return "" end | ||
if | if localize_arg=="true" then | ||
element = lang_module.get_string(element) | element = lang_module.get_string(element) | ||
end | end | ||
| Line 185: | Line 293: | ||
if (hero == nil) then return "Hero not found, must be unlocalized" end | if (hero == nil) then return "Hero not found, must be unlocalized" end | ||
local template_title = 'PageRef' | local template_title = 'PageRef' | ||
for i, item_key in ipairs(hero["RecommendedItems"]) do | for i, item_key in ipairs(hero["RecommendedItems"] or {}) do | ||
template_args = {} | local template_args = {} | ||
template_args[1] = lang_module.get_string(item_key, 'en') | template_args[1] = lang_module.get_string(item_key, 'en') | ||
template_args['alt_name'] = localize(item_key, item_key) | template_args['alt_name'] = localize(item_key, item_key) | ||
| Line 194: | Line 302: | ||
return str | return str | ||
end | end | ||
--If the hero scales with the stat, it returns {{Ss|value}} or {{Ls|value}}, else blank string | --If the hero scales with the stat, it returns {{Ss|value}} or {{Ls|value}}, else blank string | ||
| Line 205: | Line 312: | ||
local no_template = frame.args["no_template"] | local no_template = frame.args["no_template"] | ||
local hero_data = | local hero_data = hero_by_key_or_name(hero_key) | ||
if(hero_data == nil) then return "Hero not found." end | if(hero_data == nil) then return "Hero not found." end | ||
local | local scaling_value = raw_scaling(hero_data, scaling_type, hero_stat_key) | ||
if scaling_value == nil then return "" end | if scaling_value == nil then return "" end | ||
| Line 226: | Line 329: | ||
end | end | ||
if no_template == "true" then | |||
return scaling_value | |||
end | |||
return p.write_scalar_str(scaling_value, scaling_type) | |||
end | end | ||
| Line 238: | Line 339: | ||
-- Returns "true" if found, nil if not (for #if templates) | -- Returns "true" if found, nil if not (for #if templates) | ||
p.hero_has_stat = function(frame) | p.hero_has_stat = function(frame) | ||
local hero_key = frame.args[1] | |||
local stat_key = frame.args[2] | |||
if (hero_key == nil) then return nil end | |||
local hero_data = hero_by_key_or_name(hero_key) | |||
if (hero_data == nil) then return nil end | |||
if p.has_stat(hero_data, stat_key) then return "true" end | |||
return nil | |||
end | |||
-- Function to call hero tags based on name | |||
p.get_hero_tag = function (frame) | |||
local name = frame.args[1] | |||
local number = tonumber(frame.args[2]) | |||
-- Validate input | |||
if not name then | |||
return "Error: Missing name input." | |||
end | |||
if number ~= 1 and number ~= 2 and number ~= 3 then | |||
return string.format("Error: Invalid number '%s'. Must be 1, 2, or 3.", tostring(frame.args[2])) | |||
end | |||
if TAG_NAME_MAP[name] == nil then | |||
return string.format("Error: Unknown name '%s'.", name) | |||
end | |||
return p.hero_tag(name, number) | |||
end | |||
--{{#invoke:HeroData|has_tags|HERO_ENGLISH_NAME}}-- | |||
-- 'true' when the hero has roster tags, '' otherwise. | |||
function p.has_tags(frame) | |||
if p.hero_tag(frame.args[1], 1) ~= '' then return 'true' end | |||
return '' | |||
end | end | ||
| Line 289: | Line 401: | ||
return template_call:gsub("\n", ""):gsub("\r", "") | return template_call:gsub("\n", ""):gsub("\r", "") | ||
end | end | ||
| Line 404: | Line 411: | ||
[0.72] = {}, | [0.72] = {}, | ||
} | } | ||
-- Collect heroes | -- Collect heroes | ||
for hero_key, hero_data in pairs(heroes_data) do | for hero_key, hero_data in pairs(heroes_data) do | ||
if not hero_data.InDevelopment and not hero_data.IsDisabled then | if not hero_data.InDevelopment and not hero_data.IsDisabled then | ||
local dash = | local dash = p.get_stat(hero_data, "GroundDashDuration") | ||
if dash and buckets[dash] then | if dash and buckets[dash] then | ||
table.insert(buckets[dash], hero_data.Name or hero_key) | table.insert(buckets[dash], hero_data.Name or hero_key) | ||